Repository navigation
chore: bump @inkcre/ui-web to 2.5.0 - #158
Merged
Merged
Conversation
The password visibility toggle for InkInput (InKCre/ui#63, released as @inkcre/ui-web@2.4.0) never reached production because impl-ts pins the npm package and the UI changes were only linked locally via link:../ui. Bump both consumers and allow 2.4.0 in the minimumReleaseAge allowlist.
The native Module Federation snapshot validates shared dependency versions between the core package and extension packages; twitter also pins @inkcre/ui-web and must move in lockstep.
The telemetry InkSwitch has rendered at its md default (100x36) since #151 replaced the native checkbox; it was intended to be sm (80x24).
2.5.0 ships the password visibility toggle (2.4.0) and the InkSwitch size scale remap: md is now 80x24 (the previous sm), which is the intended density for the settings telemetry switch, so drop the interim size="sm" override and let the default apply. Also bumps the twitter extension pin so the native Module Federation snapshot keeps shared dependency versions in lockstep.
xiaoland
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
设置页两处 UI 问题同源——impl-ts 消费 npm 包
@inkcre/ui-web，而相关 UI 变更只在 ui 仓库源码里（此前本地经link:../ui可见）：md档 100×36 相对 12px 字体和表单密度显大链路
minimumReleaseAgeExclude白名单 + 撤掉遥测开关的临时size="sm"（新默认 md 即目标观感）验证
pnpm check全绿（含 Workspace contract 与 native 快照重建）showPasswordToggle（默认true）