Skip to content

test: make strided out tests compare against an independent reference #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antonwolfy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

test: make strided out tests compare against an independent reference #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6d63fd
test: make strided `out` tests compare against an independent reference
antonwolfy Oct 6, 2026
83babdb
Merge branch 'master' into fix/strided-out-tests
antonwolfy Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 21 additions & 9 deletions mkl_fft/tests/test_fft1d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,14 +357,18 @@ def test_array6(self):
def test_fft_out_strided(axis, func):
shape = (20, 33, 54)
x = rnd.random(shape) + 1j * rnd.random(shape)
out = np.empty(shape, dtype=x.dtype)
base = np.full(shape, -1 - 1j)

x = x[::2, ::3, ::4]
out = np.empty(x.shape, dtype=x.dtype)
out = base[::2, ::3, ::4]
result = getattr(mkl_fft, func)(x, axis=axis, out=out)
expected = getattr(np.fft, func)(x, axis=axis, out=out)
expected = getattr(np.fft, func)(x, axis=axis)

assert result is out
assert_allclose(result, expected)
# nothing outside of out was written to
out[...] = -1 - 1j
assert np.all(base == -1 - 1j)


@requires_numpy_2
Expand All @@ -378,14 +382,18 @@ def test_rfft_out_strided(axis):
out_sh = (20, 18, 54)
else: # axis == 2
out_sh = (20, 33, 32)
out = np.empty(out_sh, dtype=np.complex128)
base = np.full(out_sh, -1 - 1j)

x = x[::2, ::3, ::4]
out = out[::2, ::3, ::4]
out = base[::2, ::3, ::4]
result = mkl_fft.rfft(x, axis=axis, out=out)
expected = np.fft.rfft(x, axis=axis, out=out)
expected = np.fft.rfft(x, axis=axis)

assert result is out
assert_allclose(result, expected)
# nothing outside of out was written to
out[...] = -1 - 1j
assert np.all(base == -1 - 1j)


@requires_numpy_2
Expand All @@ -399,14 +407,18 @@ def test_irfft_out_strided(axis):
out_sh = (20, 60, 54)
else: # axis == 2
out_sh = (20, 33, 104)
out = np.empty(out_sh, dtype=np.float64)
base = np.full(out_sh, -1.0)

x = x[::2, ::3, ::4]
out = out[::2, ::3, ::4]
out = base[::2, ::3, ::4]
result = mkl_fft.irfft(x, axis=axis, out=out)
expected = np.fft.irfft(x, axis=axis, out=out)
expected = np.fft.irfft(x, axis=axis)

assert result is out
assert_allclose(result, expected)
# nothing outside of out was written to
out[...] = -1.0
assert np.all(base == -1.0)


@requires_numpy_2
Expand Down
10 changes: 7 additions & 3 deletions mkl_fft/tests/test_fftnd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,14 +299,18 @@ def test_repeated_axes(dtype, axes, func):
def test_out_strided(axes, func):
shape = (20, 30, 40)
x = rnd.random(shape) + 1j * rnd.random(shape)
out = np.empty(shape, dtype=x.dtype)
base = np.full(shape, -1 - 1j)

x = x[::2, ::3, ::4]
out = out[::2, ::3, ::4]
out = base[::2, ::3, ::4]
result = getattr(mkl_fft, func)(x, axes=axes, out=out)
expected = getattr(np.fft, func)(x, axes=axes, out=out)
expected = getattr(np.fft, func)(x, axes=axes)

assert result is out
assert_allclose(result, expected, strict=True)
# nothing outside of out was written to
out[...] = -1 - 1j
assert np.all(base == -1 - 1j)


@pytest.mark.parametrize(
Expand Down
Loading