Repository navigation
feat(data): default Plutus data to PLUTUS_DATA_OPTIONS - #617
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Plutus data default was
CBOR.CML_DATA_DEFAULT_OPTIONS, which writes non-empty maps indefinite. The node writes them definite, so for any datum holding a map,Data.toDatumHashgave a hash a validator never computes on chain, and inline datums, witness datums and redeemer data carried maps in a layout the node does not produce.Data.DEFAULT_CBOR_OPTIONSis nowCBOR.PLUTUS_DATA_OPTIONS, andCBOR.TX_DEFAULT_OPTIONS.plutusDataandCBOR.toTxCodecOptionsfollow it. Only data holding a non-empty map changes, and only in its map headers:Data.map([[1n, 2n]])wasbf0102ffand is nowa10102, and the default datum hash of such data equals the node's. Explicit presets keep their bytes, decoding is unchanged, and decoded transactions keep the original bytes of their datums and redeemers.CBOR.CML_DATA_DEFAULT_OPTIONSis deprecated with a description of what it writes, and stays available to reproduce bytes and hashes made before this change.Closes #395