Repository navigation
Ask the scope before provisioning when an agent enters there - #37
Merged
Merged
Conversation
The provisioning skill's first command, agent question opening, now prints the scope screen until Step 0 is recorded, and a status read reports next.kind scope ahead of every Google and Iterable step. Code still waits for provisioning, as preflight already routes it. Plugin 26.10.9-beta. Co-authored-by: Cursor <cursoragent@cursor.com>
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#35 gates Step 0 in
bin/agent preflight, but only an agent that enters through the platform skill reaches preflight. An agent that opensiterable-provisionbecause Firebase or the API keys are missing follows that skill's own first command,bin/agent question opening, and starts provisioning without the scope. #35 noted this as out of scope ("Entering provisioning directly ... isn't gated"). In a live run the agent went straight to the Firebase setup without asking the features or the identity.This keeps #35 and closes that entry point, so the order is always scope, then provisioning, then code:
agent question openingandchoose_driverprint the scope screen until Step 0 is recorded. With the scope recorded, the same command is the setup question, unchanged.bin/agent) reportsnext.kind: scope, with the scope screen asnext.question, ahead of every Google and Iterable step (choose_driver,run_in_terminal,authenticate,choose_target,project_unreachable,approve_firebase,register_app,provision,iterable_keys). Device and proof steps are not gated, because the code exists by then.provisionahead ofintegrate; that is unchanged.iterable-provision/SKILL.mdsays Step 0 comes first and adds ascoperow to the state table.INTENDED-FLOW.mdW1 names the provisioning entry.Version
26.10.9-beta.How it was tested
tests/agent-scope.shgains five checks: with no scope,question openingandquestion choose_driverare the features screen and nothing is written; a status read reportsscopewith the features screen; with the scope recorded, both return to the setup screens.agent-questions,agent-transitionsandtext-surfacetest the setup screens themselves, so they now record a scope in their environment first (the step 4 wording check runs with no identity, as before).agent-scope,agent-questions,agent-transitions,text-surface,agent-preflight,agent-next-action,no-bare-commands,android-userid-proof,plugin-manifests. The fulltests/run-all.shwas not run.