Repository navigation
fix: parse pod start timestamps in UTC - #15
Open
Hanabi9248 wants to merge 2 commits into
Open
Hanabi9248 wants to merge 2 commits into
Hanabi9248 wants to merge 2 commits into
Conversation
Author
|
Could a maintainer review this UTC parsing fix and approve the pending Code Format Check and Unit Test workflows when convenient? The six focused JUnit regressions pass locally across the tested server time zones. The full Maven build was blocked by dependency-download TLS failures, so the upstream checks would help complete validation. Happy to adjust the approach based on review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CommonUtil.stringToDatetreats the trailingZas a literal but leaves the formatter in the JVM default time zone. For example,2026-09-23T14:00:00Zbecomes 06:00 UTC on an Asia/Shanghai server.isAllPodRebuildcompares that result with the instance update time during upgrade and autoscaling callbacks. A newly started pod can therefore be treated as older than the update. Set the formatter to UTC so the comparison uses the actual start instant.The regression tests cover UTC, Asia/Shanghai and America/Los_Angeles, including pod timestamps on either side of an instance update. Running them against the original implementation produces four failures out of six; all six pass with this change.
Validation: compiled the real utility classes and ran JUnit 4 with Java 8 target bytecode on JDK 25 (Lombok 1.18.42 for that compiler). The Maven reactor test attempt stopped during dependency/plugin downloads with TLS handshake failures; a complete Maven build and Kubernetes integration test have not run.