Repository navigation
Fix /project/0 crash when creating a new project - #12
Merged
Merged
Conversation
Django 5+ rejects filtering Script by an unsaved Project instance. Use an empty queryset for the new-project form path, and set a build-time DJANGO_SECRET_KEY so compilemessages succeeds in Docker. Co-authored-by: Jochen Krapf <jkdesign@me.com>
Removing star-imports left Gadget/SFX undefined in apply_breakdown and the scene form queryset setup, crashing /scene/ and CI breakdown tests. Co-authored-by: Jochen Krapf <jkdesign@me.com>
getOrderNumber treated refIndex 0 as missing (if not refIndex), so New relative to the first scene redirected to /script/0/None. Empty lists now get ORDER_STEP; script/scene/shot New harden None; templates link empty scripts/scenes to /script/0/0 and /scene/0/<type>/0. Co-authored-by: Jochen Krapf <jkdesign@me.com>
Co-authored-by: Jochen Krapf <jkdesign@me.com>
On /script/0/0 the selected Scene exists but has pk=None; testing selected_scene alone still produced /script/new/None/. Same for scene/shot. Co-authored-by: Jochen Krapf <jkdesign@me.com>
New scene form prefills "New Scene", shows a banner, focuses the name field, and surfaces validation errors. Guard missing project/script, coerce order to int, and activate the scene after save. Also: scoped /script|scene|shot/0/... routes, wire shot New URL, fix project.html None links on unsaved project, redirect shot save/delete to /shot/. Co-authored-by: Jochen Krapf <jkdesign@me.com>
Scene/Shot List menus linked to /test which rendered a missing report/scene_cards.html. Point nav at /report/C/script and /report/L/simple_scene; make legacy cards() use cards_script.html. Co-authored-by: Jochen Krapf <jkdesign@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Live-instance bugs from Django modernization / order helpers / New UX / reports:
/project/0—ValueErrorfilteringScriptby an unsavedProject./scene/—NameError: Gadget/SFXafter star-import cleanup./script/0/None404 —getOrderNumbertreated index0as missing./testTemplateDoesNotExist — Scene/Shot List linked to missingscene_cards.html; now points to/report/C/script(+ simple list); legacy/testusescards_script.html.Also in this PR (audit)
/p/…/s/…/script|scene|shot/0/…shot/0/<type>/<order>+shot/new/…project.htmlNew Script/Export no longer emit/project/None/…/shot/Test plan
/project/0and new-scene create/save/script/<id>/test,/report/C/script,/report/L/simple_scene→ 200 (no TemplateDoesNotExist)cards_script.html