Repository navigation
docs(conventions): Command.get and Method.get do more than fold, against registry-protocol.rst's "a folding override carries only the fold" #2553
Description
From the 2026-11-01 conventions audit, re-verified on 73add05a3. registry-protocol.rst, "RFC-Directed Case Sensitivity": a folding override carries only the fold, TransportProtocol.get being the example; "get Override Obligations": an override that diverges from the base's contract is a defect, not a local judgement.
Command.getinpcapkit/const/ftp/command.pyfolds and also (1) returns_unregistered_member(default if default is not None else key, name)on a name miss, where the base raisesEnumKeyError(Command.get('xyzzy')returns aCommand.XYZZYwith value'xyzzy'); (2) usesdefaultas that member's value, where the base'sdefaultmust name a registered value; (3) sends a non-strkey tosuper().get(key)withoutdefault, soCommand.get(5, 'USER')raisesEnumValueErrorwhereEnumLookup.getreturnsUSER.Method.getinpcapkit/const/http/method.pydoes (1) to (3) with no fold.- Both docstrings disclose this, (1) following const: bring the 16 bespoke registries onto EnumRegistry, after fixing the base's str-key dispatch #860's no-mint ruling and (3) fix(const): Command.get calls key.upper() on any key, so bytes mint and ints raise AttributeError #1824's fix; (2) is documented but traced to no ruling. The page describes
Method.get's unregistered member as intended near its end, not as an exception to the two rules above, so it contradicts itself.
Decision needed: are these exceptions or defects?
- Exceptions: state them on the page, naming const: bring the 16 bespoke registries onto EnumRegistry, after fixing the base's str-key dispatch #860 and fix(const): Command.get calls key.upper() on any key, so bytes mint and ints raise AttributeError #1824 and what
defaultmeans on these two classes. - Defects: conform both overrides to the base (observable:
Command.get('xyzzy')andMethod.get('ZZZ')raise instead of returning a member).
Recommendation: 1, because the docstrings already document all three and (1) is the no-mint design const: bring the 16 bespoke registries onto EnumRegistry, after fixing the base's str-key dispatch #860 settled; ask the owner about (2), the one point no ruling covers.
Fix: per the decision; option 1 edits registry-protocol.rst, which feat(registry): foundation.registry wrappers for IPX and SCTP sub-maps; record the convention (#2511) #2521 also edits.
Activity
JarryShaw commentedon Nov 1, 2026
Take 1. Case insensitive and Python naming conventions.
JarryShaw commentedon Nov 1, 2026
Owner chose 1, paraphrased: these are exceptions, not defects. registry-protocol.rst states them:
The page also says what
defaultmeans onCommandandMethod, and stops callingMethod.get's unregistered member intended in a way that contradicts the two rules above it.Blocked: this edits registry-protocol.rst, which #2521 also edits, so it unblocks when #2521 merges. It then joins #2551, #2552, #2556 and #2565 in one worker.
JarryShaw commentedon Nov 1, 2026
Unblocked: #2521 merged, so registry-protocol.rst is free. Dispatched together with the page's other queued fixes (#2551, #2552, #2553, #2556, #2565) as one worker and one PR.