Repository navigation
test(project): guard protocol class member order (#2490) - #2541
Merged
Merged
Conversation
- protocol-member-order.rst: cite #2490 for the ruling; a registry fallback read()/make() names is a specific reader; specific sets open with the registry default; every helper read(), make() and the registries do not reach goes last (d); the guard noted. - tests/project: audit every protocol class for group order, _make_data() first, reader before maker and rule b; stale or unknown exceptions fail. Merge after #2522, #2523 and the held link and misc/schema/protocol reorders: the table matches main with all four merged, and plain main fails.
JarryShaw
added
test
Owner
Author
|
Cross-review (Sonnet) at |
JarryShaw
added
the
review: good-to-go
Contributor
|
Coverage: 93.94% (unit tier, Python 3.15,
Per-file detail: the |
JarryShaw
removed
the
review: good-to-go
JarryShaw
added a commit
that referenced
this pull request
Nov 1, 2026
#2490, #2575) #2541's exception table was built on a base without #2528 and #2542, so main fails the member-order guard: #2528 put DTLS back in order, and #2542 renamed the IGMP classes to IGMPv3. Drop DTLS and re-key the IGMP entries. #2509 merged before #2521 required a wrapper for every class-level map, so Radiotap.__proto__ has none. Nothing dispatches by it yet; excuse it until #2575 adds Radiotap.register and register_radiotap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseconst— regenerates constant or registry tables, members keeping their numeric valuesDescription of your pull request and other information
Part of #2490. Merge after #2522, #2523, #2538 and #2539. Its exception table matches
mainonce all four reorders are in, so it fails on plainmainby design until then.tests/project: audits every protocol class for group order,_make_data()first, reader before maker, and rule (b). An exception that has gone stale or names an unknown member fails.DTLS [data]exception entry.