Repository navigation
refactor(corekit): move the Internet checksum into corekit.checksum.internet - #2586
Merged
Merged
Conversation
Owner
Author
|
GOOD TO GO at
|
…nternet (#2580) pcapkit.corekit.checksum is a package with one module per checksum family; internet.py holds the protocol-independent part of the old pcapkit.protocols.misc.checksum.checksum: ChecksumStatus, the RFC 1071 sum, verify_checksum, fragment_payload and its _in_fragment, and _rebuilding, moved from pcapkit.protocols.protocol. It imports nothing from pcapkit.protocols. The IP-specific pseudo_header and verify_upper join IP_Pseudo in ip_pseudo.py, and checksum.py is gone. The old path never shipped, so there is no re-export and no versionremoved. Every import and reference is retargeted; the docs get a corekit page, and the placement is recorded on utilities-or-corekit.rst. test_checksum_import_boundary_2580_unit checks the package's imports.
Owner
Author
|
Resolve conflicts |
Owner
Author
|
On it. The conflicts come from #2544 and #2583 merging into |
Owner
Author
|
Rebased onto
|
JarryShaw
force-pushed
the
refactor/2580-corekit-checksum
branch
from
November 1, 2026 19:05
c73728d to
e54460d
Compare
5 tasks done
Contributor
|
Coverage: 94.02% (unit tier, Python 3.15,
Per-file detail: the |
JarryShaw
added a commit
that referenced
this pull request
Nov 2, 2026
…1.6.0 (#2449) - Added: DCCP, its checksum over the IP pseudo-header, register_dccp and register_dccp_option, and the pcapkit.const.dccp registries (#2593). - Folded into unreleased entries: LinuxSLL's stop on its ARPHRD path (#2587) and ARPHRD's __proto_dest__ (#2598), SSLv2 records chained in a segment (#2585), the checksum's move to pcapkit.corekit.checksum.internet (#2586), and IGMPv2's and IGMPv3's versioned name (#2590). - Breaking: InARP moves to pcapkit.protocols.link.inarp with no re-export, joining the DRARP entry (#2596). - Changed: the conventions' new rulings (#2599), the milestone workflow's next-open-milestone lookup (#2591), the PyPy protocols shards (#2604). Fixed: a handled next-layer refusal is quiet under beholder (#2597); the IPX crawlers restore sys.path (#2601). - CHANGELOG.md regenerated; util/changelog_md.py --check passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
refactor— changes neither behaviour nor performanceDescription of your pull request and other information
The owner's option 1(a) on #2580. The Internet checksum helpers move into
pcapkit.corekit.checksum.internet:ChecksumStatus,internet_checksum,compute_checksum,verify_checksum,partial_checksum,fragment_payloadand the private_rebuilding. Protocol code no longer imports them from protocols-level modules.pseudo_headerandverify_uppersit besideIP_Pseudoinpcapkit.protocols.misc.checksum.ip_pseudo.Not breaking: the old module was never released and
_rebuildingis private, so there is no re-export.test_checksum_import_boundary_2580_unitkeepscorekit.checksumfree of protocols and foundation imports; the review's mutation run showed it fails on each injected violation. utilities-or-corekit.rst records the ruling.The worker's questions were settled on their recommendations: keep the strict boundary test, leave the lazy imports lazy, and do not aggregate into
corekitorpcapkit.all.Closes #2580