Skip to content

ci(milestone): give the next open milestone once the version's is closed - #2591

Merged
JarryShaw merged 1 commit into
mainfrom
ci/2548-milestone-lookup
Nov 2, 2026
Merged

JarryShaw merged 1 commit into
mainfrom
ci/2548-milestone-lookup

Conversation

@JarryShaw

Copy link
Copy Markdown
Owner

What is the purpose of your pull request?

  • ci — workflows or build tooling

Description of your pull request and other information

util/milestone.py derived the milestone title from __version__ (1.5.1, so PyPCAPKit v1.5). That milestone is closed, so new items got none. target_milestone now returns the open milestone named after __version__, or, if that one is closed, the open PyPCAPKit v<x.y> with the lowest release above it, compared as numbers so that v1.10 follows v1.9. An absent milestone, or a closed one with nothing open above it, still warns and changes nothing.

The backfill is bounded by the release before the milestone it assigns, so after a final tag it starts above the closed milestone's newest item. The milestone.yml header, workflows.rst "Milestone" and process.rst "Milestones and the Project Board" describe the lookup.

After merge, the backfill run should give PyPCAPKit v1.6 to the items above #2463.

Closes #2548

…sed (#2548)

- util/milestone.py: target_milestone replaces find_open. It returns the
  open milestone titled after __version__; where that one is closed, the
  open PyPCAPKit v<x.y> with the lowest release above it, compared as
  numbers. An absent milestone, or a closed one with none open above it,
  still warns and changes nothing; the closed case now says so.
- The backfill is bounded by the release before the milestone given, so
  after a final tag it starts above the closed milestone's newest item.
- tests/project/test_milestone_2218.py: TestTarget, plus one-item and
  backfill runs for a closed milestone and for v1.10 following v1.9.
- milestone.yml header, workflows.rst "Milestone" and process.rst
  "Milestones and the Project Board" describe the lookup and the ruling.
@JarryShaw JarryShaw added ci Pull requests that change CI or workflow configuration (ci: subject prefix) review: good-to-go Cross-review at the current head says ready; CI state is separate labels Nov 1, 2026
@JarryShaw

Copy link
Copy Markdown
Owner Author

GOOD TO GO at b45b64328 (Sonnet review). target_milestone falls back to the lowest open PyPCAPKit v<x.y> above a closed one, compared as numbers so that v1.10 follows v1.9. The backfill bound moves past the closed milestone's newest item. test_milestone_2218 pins a closed milestone and v1.10 following v1.9.

@JarryShaw JarryShaw moved this to In review in PyPCAPKit Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Coverage: 94.03% (unit tier, Python 3.15, b45b64328, Unit Tests run success)

Package Statements Missed Branches Partial Cover
pcapkit (top level) 104 4 20 2 95.16%
pcapkit/const 20093 144 2712 125 98.78%
pcapkit/corekit 2605 74 818 37 96.52%
pcapkit/dumpkit 281 3 100 3 98.43%
pcapkit/foundation 3360 27 1186 32 98.70%
pcapkit/interface 138 4 52 3 96.32%
pcapkit/protocols 20346 220 5370 204 98.34%
pcapkit/toolkit 961 28 342 10 96.32%
pcapkit/utilities 506 7 144 5 98.15%
pcapkit/vendor 5009 2222 1148 182 52.31%

Per-file detail: the coverage-html artifact of this run.

@JarryShaw
JarryShaw merged commit ac3efd9 into main Nov 2, 2026
67 checks passed
@JarryShaw
JarryShaw deleted the ci/2548-milestone-lookup branch November 2, 2026 02:12
@github-project-automation github-project-automation Bot moved this from In review to Done in PyPCAPKit Nov 2, 2026
@github-actions github-actions Bot added this to the PyPCAPKit v1.6 milestone Nov 2, 2026
@JarryShaw JarryShaw removed the review: good-to-go Cross-review at the current head says ready; CI state is separate label Nov 2, 2026
JarryShaw added a commit that referenced this pull request Nov 2, 2026
…1.6.0 (#2449)

- Added: DCCP, its checksum over the IP pseudo-header, register_dccp and
  register_dccp_option, and the pcapkit.const.dccp registries (#2593).
- Folded into unreleased entries: LinuxSLL's stop on its ARPHRD path
  (#2587) and ARPHRD's __proto_dest__ (#2598), SSLv2 records chained in a
  segment (#2585), the checksum's move to pcapkit.corekit.checksum.internet
  (#2586), and IGMPv2's and IGMPv3's versioned name (#2590).
- Breaking: InARP moves to pcapkit.protocols.link.inarp with no re-export,
  joining the DRARP entry (#2596).
- Changed: the conventions' new rulings (#2599), the milestone workflow's
  next-open-milestone lookup (#2591), the PyPy protocols shards (#2604).
  Fixed: a handled next-layer refusal is quiet under beholder (#2597); the
  IPX crawlers restore sys.path (#2601).
- CHANGELOG.md regenerated; util/changelog_md.py --check passes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Pull requests that change CI or workflow configuration (ci: subject prefix)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

ci: milestone.yml looks for the closed v1.5 milestone, so new items get none

1 participant