Repository navigation
refactor(protocols)!: move NoPayload into misc/no_payload.py - #2636
Merged
Merged
Conversation
JarryShaw
added
breaking
Owner
Author
|
GOOD TO GO at |
- `pcapkit.protocols.misc.null` and its `schema.misc.null` and `data.misc.null` modules move to `misc/no_payload.py`, so the module takes its class's name; the class keeps the name `NoPayload`, and nothing is re-exported at the old paths. - Every import, `:class:`/`:mod:` role, `.. module::` target, toctree entry, `ext.rst` row and class-hierarchy click target follows the move; the module and its docs page record `versionadded`/`versionremoved:: 1.6.0`. - protocol-family-grouping.rst leaves nothing pending under #2529. - Tests: `test_no_payload_path_2529_unit.py` pins `ModuleNotFoundError` on the old paths and the new homes; the #1744 ledger gains `MOVED_MODULES`, which pins the `versionremoved` notes; the existing tests import the new paths.
JarryShaw
force-pushed
the
refactor/2529-no-payload
branch
from
November 2, 2026 07:19
95032c1 to
3e5fbb2
Compare
Owner
Author
|
Fix round and rebase:
Verdict stays good to go. |
Owner
Author
Contributor
|
Coverage: 94.08% -- tests failure, so this is partial (unit tier, Python 3.15,
Per-file detail: the |
JarryShaw
removed
the
review: good-to-go
JarryShaw
added a commit
that referenced
this pull request
Nov 2, 2026
…shared value helpers into 1.6.0 (#2449) - Breaking: NoPayload and its data model and schema move from misc.null to misc.no_payload with no re-export, so a frame pickled by 1.5.x fails to load (#2636). 1.5.0's three NoPayload roles and 1.6.0's own point at misc.no_payload, 1.5.0's text unchanged. - Added: the IP, L2TP, ICMP, IGMP and LinuxSLL bases give a member on read, make and from_data, version= naming it, with the refusals and IPv4's Version check ahead of the header (#2639). - Changed: SCTP's chunk-flag and Invalid Stream Identifier reserved-octet messages (#2638). Folded into the TLS/DTLS entry: make() raises StructError for a value too wide for its field (#2638), and the DTLS_CIDCiphertext and TLS_ConnectionId package exports (#2641). - The conventions entry records the version= dispatch rule (#2639) and ARP as the member-order reference (#2638). - No entry for #2638's private value helpers or the Ethernet and PCAP-NG PAT_MAC_ADDR, as for #1844's OSPF copy; #2640's docstring fixes; or the test-only #2620, #2637, #2645 and #2646. - CHANGELOG.md regenerated; util/changelog_md.py --check passes.
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
refactor— changes neither behaviour nor performanceDescription of your pull request and other information
Breaking.
NoPayloadand itsschemaanddatamodules move frompcapkit.protocols.misc.nulltopcapkit.protocols.misc.no_payload, per the owner's rulings on #2529 (Q1, Q3, Q4). The class keeps its name. Nothing is re-exported at the old paths, so importing from them raisesModuleNotFoundError.That completes #2529: protocol-family-grouping.rst has no pending exception left. The moved module and its page carry
versionadded/versionremoved:: 1.6.0, as the 1.5.0 RARP move did. A test pins the three old paths as gone.User-visible consequences:
infostill loads.misc/null.htmltomisc/no_payload.html.1.5.0.rstkeep their text; chore(docs): centralise changelog entries for unreleased versions #2483 retargets them.A script did the rename. Every sample capture parses identically (1,632 frames), and the protocol legs pass. A Sonnet cross-review returned GOOD TO GO.
Closes #2529