[JarryShaw]

• Searched for similar pull requests
• Followed the coding style (make pylint, make mypy, make isort)
• make test passes, and a test case covers the change
• Changelog entry: N/A — centralised in chore(docs): centralise changelog entries for unreleased versions #2483

What is the purpose of your pull request?

• refactor — changes neither behaviour nor performance

---

Description of your pull request and other information

This finishes the shared value helpers on ProtocolBase from #2614's audit, and moves TLS onto them.

New helpers: _read_octets, _read_uint, _read_sint/_make_sint, _uint_size, _make_octets, _read_mac_addr/_make_mac_addr, _read_text, and alias= on _make_uint.

Adoption:

• TLS: drops its module-level _take. Every TLS hello, handshake, content and record-header maker packs through _make_pack, so an oversize value raises StructError: TLS: pack failed instead of wrapping or leaking a bare error. TLS and DTLS are not in any release.
• Ethernet: uses the base MAC helpers.
• PCAP-NG and 802.11: keep only the overrides that change behaviour.
• OSPF: checks packet_length with _make_uint(alias='OSPF').
• SCTP: the fix(protocols): makers reject bad arguments with the reader's 'invalid format' text #2296-pinned flag and cause makers use _make_octets.

Owner ruling (3): the member-order page's worked example and reference class move to ARP, so Ethernet loses its delegate and pylint pragma.

Changed messages:

• SCTP: [Chunk 132] invalid flags: must be one octet, not b'' → SCTP: invalid [Chunk 132] flags: must be 1 octet, not b''
• SCTP: [Cause 1] invalid reserved: must be two octets, not b'' → SCTP: invalid [Cause 1] reserved: must be 2 octets, not b''

The owner accepted these re-pins when choosing _make_octets.

Verification:

• Valid output is byte-identical across a 20,590-case TLS differential and 31,536 MAC maker calls.
• The new tests fail on main.
• A Sonnet cross-review's findings are folded in.

Part of #2614

[JarryShaw]

GOOD TO GO at c82e1b62c. A Sonnet cross-review differential-checked each new helper against the copies it replaces, with 0 diffs:

• 4,210 MAC inputs across Ethernet, PCAP-NG MAC/EUI, 802.11 and ARP;
• 2,019 text samples;
• 5,218 signed values;
• 270,000 _uint_size cases.

It also ran 6,625 TLS/DTLS parse/build cases. The only differences are oversize makes, which now raise StructError.

Its NEEDS CHANGES round is folded in:

• dead PAT_MAC_ADDR deleted;
• ARP is the member-order reference, per ruling 3, so Ethernet drops its pragma'd delegate;
• the TLS record header refuses oversize values;
• the _read_text error arm is tested.

The two re-pinned SCTP messages are listed in the description.

[JarryShaw]

Rebased onto main (18544c3c9): c82e1b62c → 0d23b5e3a. No conflicts. The stable patch-id 4972ab103a42 is identical, and range-diff reports =, so the patch is unchanged and the verdict stays good-to-go. The rebase brings in #2637, which fixes the red Python pypy3.11 leg. The remaining test_package_reexports_1807_unit failure is on main and is fixed in #2641.

[github-actions]

Coverage: 94.08% -- tests failure, so this is partial (unit tier, Python 3.15, 0d23b5e3a, Unit Tests run failure)

Package	Statements	Missed	Branches	Partial	Cover
pcapkit (top level)	104	4	20	2	95.16%
pcapkit/const	20561	177	2832	158	98.53%
pcapkit/corekit	2697	74	854	37	96.65%
pcapkit/dumpkit	281	3	100	3	98.43%
pcapkit/foundation	3475	27	1206	32	98.74%
pcapkit/interface	138	4	52	3	96.32%
pcapkit/protocols	21394	218	5626	196	98.45%
pcapkit/toolkit	961	28	342	10	96.32%
pcapkit/utilities	512	7	144	5	98.17%
pcapkit/vendor	5256	2260	1198	194	53.61%

Per-file detail: the coverage-html artifact of this run.

[JarryShaw]

The red Python 3.15 leg comes from this PR's base, not its change. It fails only the DTLSCIDCiphertext schema round trip, which main fixed in 16ccc4373 (#2645), and the re-export test that #2641 fixes. I'll rebase once #2641 merges. The verdict stays good to go.