Repository navigation
Conversation
- const: the four sweeps compare against tests/const/census, one module per pcapkit.const package, instead of pinned counts - vendor: the constant-miss sweep compares against a sorted crawler list - dispatch, options: each family moves to dispatch_families/ or option_families/; the census tests derive from them and the tree's maps - rfc constants: NOT_A_COPY and UNRELATED are sorted by module, and pinned so - excusals in enum_get and registry_protocol assert their reason, so the derived totals keep the pins' strength - test-coverage.rst: the suites' sources and the adding table follow - references to TCP_BASE, HIP_BASE and other moved names follow them
JarryShaw
added
test
Owner
Author
|
GOOD TO GO at |
Owner
Author
Contributor
|
Coverage: 94.08% -- tests failure, so this is partial (unit tier, Python 3.15,
Per-file detail: the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
test— tests onlyDescription of your pull request and other information
The test files that every new module or registry had to edit now derive their counts instead of pinning them. This is the restructuring #2615 allows.
tests/const/census, one module perpcapkit.constpackage.dispatch_families/oroption_families/. The census tests derive from them and from the tree's maps.CONVERTEDandEXCLUDEDlists in the enum-get and registry-protocol tests assert their own reasons, so the derived totals are as strict as the pins were.Case sets are identical to
main. Frames in the gitignoredoptions-transport.pcapandoptions-internet.pcapnow come out in file-name order. Nothing reads frame order there.A Sonnet cross-review returned GOOD TO GO and its one gap (an unchecked
CONVERTEDentry) is closed. Every const and vendor mutation fails.Closes #2615