Repository navigation
build: remove unnecessary shaded coat-libs.jar dependencies - #1481
Merged
Merged
Conversation
Remove the following dependencies from the shaded JAR (`coat-libs.jar`): | Dependency | Notes | | --- | --- | | `org.freehep:jminuit` | `calcode` may be consuming this, or the (newer) one provided by `groot`; in any case, `calcode` should depend _explicitly on this, not transitively, so let's remove it here | | `org.jama:jampack` | we don't use its `Jampack` classes anywhere here or downstream, but this dependency also includes some `Jama` classes such as `Jama.Matrix`; however, we also consume `gov.nist.math:jama` which has all the `Jama` classes we actually use | | `org.jlab.plugins:jMath` | completely unused | | `de.erichseifert:vectorgraphics2d` | unused here or anywhere downstream | | `net.objecthunter:exp4j` | unused here or anywhere downstream; however, it needs to be pinned in the parent POM's `dependencyManagement` in order to resolve a convergence conflict between `jnp-hipo4` and `jnp-hipo` (and if we can be rid of `jnp-hipo`, we can remove this pin) |
c-dilks
requested review from
Hattawy,
baltzell,
mathieuouillon,
raffaelladevita and
zieglerv
as code owners
October 7, 2026 16:10
c-dilks
enabled auto-merge (squash)
October 7, 2026 16:39
baltzell
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the following dependencies from the shaded JAR (
coat-libs.jar):org.freehep:jminuitcalcodemay be consuming this, or the (newer) one provided bygroot; in any case,calcodeshould depend explicitly on this, not transitively, so let's remove it here; note that here incoatjava, only thereconstruction/richmodule usesjminuitorg.jama:jampackJampackclasses anywhere here or downstream, but this dependency also includes someJamaclasses such asJama.Matrix; however, we also consumegov.nist.math:jamawhich has all theJamaclasses we actually use;Jamaclasses are not used downstreamorg.jlab.plugins:jMathde.erichseifert:vectorgraphics2dnet.objecthunter:exp4jdependencyManagementin order to resolve a convergence conflict betweenjnp-hipo4andjnp-hipo(and if we can be rid ofjnp-hipo, we can remove this pin)