Skip to content

build: remove dependency on org.jlab.coda:jtools - #1482

Merged
baltzell merged 1 commit into
developmentfrom
mvn-rm-jtools
Oct 7, 2026
Merged

baltzell merged 1 commit into
developmentfrom
mvn-rm-jtools

Conversation

@c-dilks

@c-dilks c-dilks commented Oct 7, 2026

Copy link
Copy Markdown
Member

For reference, here's a decompilation of the jtools JAR from clasweb (you must be signed in):
https://code.jlab.org/dilks/jarchaeology-jtools

jtools is only consumed by our

common-tools/clas-reco/src/main/java/org/jlab/clas/reco/Clas12Types.java

where it's used for 2 things:

1. org.jlab.clas12.tools.MimeType

We only use MimeType.EVIO.type() which returns the string "binary/data-evio", and is the only place where we don't hard code such a "binary/data-*" string; so, let's just hard code it to avoid the dependency.

Note

In theory, we could add such "binary/data*" strings upstream in clara-java's enumerator in

src/org/jlab/clara/engine/EngineDataType.java

along its other "binary/*" strings, or similarly in xmsg's

src/org/jlab/coda/xmsg/data/xMsgMimeType.java

but we've forked those and probably should avoid diverging from their upstream repos too much...

2. org.jlab.clas12.tools.property.JPropertyList

Used in PROPERTY_LIST, which is unused, so we can just remove it.

@baltzell
baltzell self-requested a review October 7, 2026 18:00
@baltzell
baltzell enabled auto-merge (squash) October 7, 2026 18:50
@baltzell
baltzell merged commit f53aab1 into development Oct 7, 2026
37 of 42 checks passed
@baltzell
baltzell deleted the mvn-rm-jtools branch October 7, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants