Skip to content

Fix the blood analog, port edge clearance, Explode on slide chips, and saved check thresholds - #4

Merged
Jujified merged 1 commit into
mainfrom
fix-four
Oct 19, 2026
Merged

Jujified merged 1 commit into
mainfrom
fix-four

Conversation

@Jujified

@Jujified Jujified commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

What this changes

This fixes four issues found while re-checking the documentation against the code.

  • Blood analog preset. It now uses 33.5 % glycerol by volume, which gives the ~3.5 mPa·s its note promises. At 40 % the app's own viscosity model gave ~4.8 mPa·s. The test now holds it to 3.3–3.7 mPa·s instead of 2–6.
  • Port edge clearance. channel-near-boundary now measures a port by the boss or pedestal it prints, not just its opening. A luer slip's boss is 5.9 mm across, not 4.27 mm, and the boss reaches the chip edge first. The 0.8 mm boss wall is now one constant (PORT_BOSS_WALL_MM) shared with the CAD builder, so the check and the geometry can't drift apart. A luer lock is unchanged, because its thread is already its outermost part.
  • Explode on glass-slide chips. The button now works and lifts the glass off the plate. The viewport already supported this, but the toolbar disabled the button and its tooltip called the chip monolithic.
  • Design-check thresholds are saved. Minimum printable wall, overhang limit and taper ratio now persist in the browser between sessions, like the app settings, so a wall value measured off a test print doesn't need retyping. They aren't written into the project file. On load, stored values are validated against the defaults.

How it was checked

  • npm run build && npm test && npm run lint pass. That's 405 tests, 6 of them new:
    • edge clearance with and without a boss;
    • portOuterFootprintMm;
    • restoring stored thresholds, including bad values.
  • None of the seven templates gains or loses an edge warning: I ran the check across all of them before and after the change.
  • The blood analog figure comes from the app's own Cheng (2008) model at 20 °C: 33.5 % by volume gives 3.52 mPa·s.

- Blood analog preset: 33.5 % glycerol by volume, which gives the
  ~3.5 mPa·s its note promises. 40 % gave ~4.8. The test now holds it to
  3.3–3.7 mPa·s rather than anywhere from 2 to 6.
- Edge clearance measures a port by the boss or pedestal it prints, not
  just its opening. A luer slip's boss is 5.9 mm across, not 4.27. The
  0.8 mm boss wall is now one constant shared with the CAD builder.
- Explode works on glass-slide chips: it lifts the glass, which the
  viewport already supported but the toolbar disabled.
- Design-check thresholds persist in the browser between sessions, with
  stored values validated against the defaults on load.
Copilot AI balanced review requested due to automatic review settings October 19, 2026 00:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vercel

vercel Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
open-chip Ready Ready Preview Oct 19, 2026 12:56am UTC

@Jujified
Jujified merged commit b929747 into main Oct 19, 2026
3 checks passed

This branch was successfully deployed

1 active deployment
Preview — f0022de5 Deployed Oct 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants