Repository navigation
UI named entrypoints replace /exec, in one api package - #1133
Merged
Merged
Conversation
Three named routes, /document/create, /document/update and /document/delete, with the python in ui/server/document_api/. Each answers the whole project, so the write-then-reload pairs become one call. No per-document read: /project/documents already brings them all, so PreviewPanel reads the store. Duplicate builds each copy from the store too, and the free-name rule moves to TypeScript. Gone: buildAddDocumentCode, buildNotebookCommand, fetchDocument and stringifyToPython. Eight exec call sites left, all repos.
A repo row's double click loaded it into the project, so no row ever reached the details panel and DetailsViewRepo never showed. Lost in #1122, when single click stopped opening. Now a double click opens the row, like the document tree. Loading into the project stays on the right click menu.
Four routes under /repository/*, python in ui/server/repository_api/. Paths cross the wire, not repository names. A load answers added and problems, so one that added nothing says why. matplotlib, rasterio and Unum join requirements-minimal.txt: without them no toolkit in a repository can be built.
requirements-minimal.txt holds names only, minimal_requirements.py takes the pins, the dockerfile pipes them into pip. Plus the plan for the next three tasks.
All server calls move to src/api/, on an ApiCall base class that does the fetching. Toasts come in through a reporter, so src/api/ imports no React, no store and no snackbar. entrypoint.ts and the pure fetchers are gone. src/io/ keeps the components, the snackbar and the store-writing wrappers.
requirements-server.txt and requirements-integ.txt are gone. requirements-minimal.txt had all their names but pytest. The two CI jobs that installed them build the minimal set with the script instead.
Runs the ui/server pytest suite in the hera-server image, with the repo mounted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.