Repository navigation
feat(engines): page composer for the layout engine - #840
Merged
Merged
Conversation
…ooters, page numbers, inline pictures Replaces the interim page flow. Sections' paper, margins and gutter; page and column breaks; keep lines together, keep with next, widow and orphan control; 한글's stored page breaks and places while the page follows them; headers and footers for both, odd and even pages and a hidden first page; page numbers across sections and restarts, page number and total pages fields (a first pass for the body's total); pictures laid out like characters; formats of other documents resolved through the 한글 style first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
KnifeLemon
changed the base branch from
engine/stored-lines
to
builtin-engines
October 30, 2026 16:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Implements the Project 4 item "Layout engine: page composer". It replaces the interim page flow from #834.
Stacked on #839 (stored line layout). The base is
engine/stored-lines; it moves tobuiltin-enginesonce #839 is merged.Page composer (
Typesetting/PageComposer.cs)StyleResolver, every paragraph and run is resolved before layout, as the HWPX writer would write it.Tables are still stacked cell by cell (the tables item). Columns, notes, floating objects and master pages are separate items too.
Acceptance
Tests
PageComposerTestscovers:RepositoryFonts(the pinned Noto fonts as a font collection) moves out ofParagraphLayoutTestsso both test classes share it. Engines suite locally: 2326 passed, 0 failed.🤖 Generated with Claude Code