Repository navigation
Merge the one duplicate individual; explain why other label matches stay apart - #148
Merged
Merged
Conversation
…s stay apart Reviewed all 428 groups of individuals in ari_t1d.owl that share a label. Only Raynaud's (ARI:0001176) held a true duplicate: "Bluish coloring of hands/feet" twice with no other data, so Sym_0001176_1701 and its hasSymptom link are removed and the disease gets an ARI_ChangeLog line. The rest are per-disease records (different steps, figures, triggers and values under a shared heading label), different classes with the same name, or identical individuals the editor treats as owned by one disease: its delete destroys the entity and its edits write on the individual, so a shared one would be removed or changed for every disease at once. The changelog entry gives the counts and reasons. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewed every set of individuals in
ontologies/ari_t1d.owlthat share a label (case-insensitive): 428 groups, 4,192 of 6,674 individuals.Merged (1): Raynaud's (
ARI:0001176) listed "Bluish coloring of hands/feet" twice (Sym_0001176_1700,Sym_0001176_1701), with no other data on either._1701and itshasSymptomlink are removed, and the disease gets anARI_ChangeLogline.Not merged, and why. In this model each individual is "this symptom/antibody/cell in this disease", and it holds that disease's data.
delete_itemcallsdestroy_entity, so removing "Pain" from one disease would remove it from all 94. Edits write on the individual, so a likelihood or obsolete flag set for one disease would show on all of them. 6 groups also disagree onARI_Obsolete.Symptoms already have a shared identity in
notebook/symptom-mapping/ari_symptoms.owl(oneARIS:concept per string, plus 63 synonym merges that label matching can't find). Sharing across diseases should link per-disease individuals to that concept, not collapse them.Test plan
python .github/scripts/validate_mappings.py --since main: 0 errors, 0 warnings🤖 Generated with Claude Code