Repository navigation
fix(todo): retry request timeouts while caller remains active - #235
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todo reads stopped after the first HTTP client timeout because it also matches
context.DeadlineExceeded. Distinguish the caller's cancelled/expired context from an individual HTTP attempt's timeout, then use the existing three-attempt read budget. Authorization and malformed responses remain non-retryable; mutation delivery is unchanged.Native HTTP regressions reproduce both header and body timeouts, recover the list-to-numbered-completion flow, stop on caller cancellation/deadline, and prove a timed-out completion stays unknown with one PATCH. CI validation and local checks passed on
8edab66: 1,563 race tests; 19 requirements / 76 native semantic cases; build/vet/lint, deployment/OpenAPI scripts, Compose and generated consistency. Rust fmt/clippy, 46 tests, release build and all 16 current plus seven reference card renders passed.Part of #233. This fixes a reproduced current timeout-handling defect. The historical reported incident remains unconfirmed, so the Task stays open.