Repository navigation
fix(napcat): preserve structured replies without media diagnostics - #237
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structured OneBot replies now stay ordered reply parts instead of becoming unknown attachments or emitting media diagnostics. Regression tests exercise the real enrichment path for structured replies, flat segments with existing CQ references, CQ controls, inline/fetched forwards and mixed attachments, preserving reply references, adjacent text and forward boundaries.
Closes #236. Part of #224; the original attachment report's cause remains unconfirmed.
Local checks passed on
f3c93ff: full Go race suite (23 packages, 1,571 tests/subtests), 19 specification requirements / 76 native semantic cases, vet/lint/build, deployment/OpenAPI scripts, generated-client verification and Compose. Renderer fmt/clippy, 46 Rust tests, release build, 16 current card fixtures and 7 pinned reference fixtures also passed.Automatic CI passed Verify, Renderd and Lint on
f3c93ff; both CodeQL analyses also passed.