Repository navigation
refactor(school): consume shared CAS protocols - #106
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delegate the actual school CAS login targets, service URLs, page parsing, form construction and result checks to released
client-core v0.8.0. Remove the local protocol and password-transformation helpers while preserving HTTP execution, headers, cookies, target/session-priming order and retries.The same 27 CAS regression events passed against the original v0.7 CLI and this consumer. Full build, clean committed race/specification evidence (667 passing test events across 33 packages; 54/54 cases covering 24 requirements), OpenAPI checks, vet and lint pass. Generated code is unchanged; no local module replacement remains. Passing CI and native evidence.
Closes #105. Part of Life-USTC/client-core#12; paired with Life-USTC/client-core#21.