Repository navigation
ci: rename ruff.yml to ci.yml, add timeouts/concurrency, cache Playwright browsers - #95
Merged
Merged
Conversation
…ight browsers - Rename the workflow file ruff.yml -> ci.yml and its name to CI: it runs lint, format and the full unittest suite, not just ruff. The required status context is the job name, and the job id/name `ruff` is unchanged, so branch protection is unaffected. - Add timeout-minutes: 10 and concurrency with cancel-in-progress so superseded PR runs stop early. - uv sync --group dev -> uv sync --frozen --group dev to fail on lockfile drift instead of silently re-resolving. - build.yml: cache ~/.cache/ms-playwright keyed on the patchright version pinned in uv.lock, so `patchright install chromium` stops re-downloading ~150 MB on every daily run. actions/cache SHA-pinned to match the repo's pinning style. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ruff.yml→ci.yml(git mv, 81% similarity)The workflow runs ruff lint, ruff format, and the full unittest suite with coverage, so the file and workflow
name:now say CI. The required status context is the job name: the job has noname:key, so the context is its idruff(ci.yml:17), which is untouched — branch protection keeps matching. Same for CodeQL's "Analyze (python)" (codeql.yml:16), which this PR does not touch.Hardening in
ci.ymlconcurrencywithcancel-in-progress: true(ci.yml:12-14) — superseded runs on the same ref stop early.timeout-minutes: 10(ci.yml:19); the suite takes ~70s locally.uv sync --group dev→uv sync --frozen --group dev(ci.yml:25) so lockfile drift fails loudly instead of being silently re-resolved.Playwright browser cache in
build.ymlpatchright install chromium(build.yml:50) re-downloaded ~150 MB of Chromium on every daily scheduled run. Two new steps before it (build.yml:33-44):uv.lock(currently 1.63.0);actions/cacheon~/.cache/ms-playwrightkeyedms-playwright-${{ runner.os }}-patchright-<version>, so the browser only downloads again when the patchright pin changes.actions/cacheis SHA-pinned (0057852b…# v4.3.0, resolved viagh api repos/actions/cache/git/ref/tags/v4) matching the repo's existing pinned style.Validation
actionlintclean on ci.yml and build.ymluv sync --frozen --group dev— OKuv run ruff check . --output-format=githubanduv run ruff format --check .— clean (53 files already formatted)uv run coverage run -m unittest discover -s tests -p 'test_*.py'— 92 tests, OK; coverage 85%grep -A1 '^name = "patchright"$' uv.lock→ 1.63.0🤖 Generated with Claude Code