Repository navigation
fix(tabs): stop baking trigger id/value; delegate highlight to root listener - #42
Open
elviskahoro wants to merge 2 commits into
Open
elviskahoro wants to merge 2 commits into
elviskahoro wants to merge 2 commits into
Conversation
…istener Triggers no longer generate a build-time id or interpolate the value into per-trigger JS (broken under rx.foreach). tabs.root attaches one delegated click listener that reads data-value from the DOM. Adds regression tests and regenerated docs. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TabsTrigger.createbaked a UUID id and the trigger value into per-triggercall_scriptJS, which breaks underrx.foreach. Highlighting is now handled by one delegated click listener plus a mount pass, readingdata-valuefrom the DOM. Useron_click/on_mounthandlers are preserved, and the nested-tabs scope guard from #30 is kept.Stacked on #30: this branch includes #30's commit, so the diff here shows both until #30 merges. Review the last commit only.
Testing
New
tests/test_tabs.pycases cover no baked id/JS, the delegated handler, handler preservation and nested scoping; the full suite passes (346). Docs regenerated.🤖 Generated with Claude Code