Skip to content

test: remove Oxlint suppressions - #75

Merged
GuillaumeRx merged 2 commits into
mainfrom
gr/remove-oxlint-suppressions
Oct 12, 2026
Merged

GuillaumeRx merged 2 commits into
mainfrom
gr/remove-oxlint-suppressions

Conversation

@GuillaumeRx

@GuillaumeRx GuillaumeRx commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Explanation

The repository-wide Oxlint suppression file hides test lint violations in apply-release-plan and create-package. This PR removes the suppression file and fixes the underlying test code instead.

The fixes move repeated changed-file validation into a shared test helper, replace conditional expectations with unconditional assertions, use every instead of a conditional reducer, and move the mocked file lookup into a helper.

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@GuillaumeRx
GuillaumeRx marked this pull request as ready for review October 12, 2026 09:55
@GuillaumeRx
GuillaumeRx requested a review from a team as a code owner October 12, 2026 09:55
@GuillaumeRx
GuillaumeRx enabled auto-merge October 12, 2026 09:56
@GuillaumeRx
GuillaumeRx deployed to default-branch October 12, 2026 09:56 — with GitHub Actions Active
Comment thread packages/apply-release-plan/src/index.test.ts Outdated
@GuillaumeRx
GuillaumeRx added this pull request to the merge queue Oct 12, 2026
Merged via the queue into main with commit b2b354d Oct 12, 2026
45 checks passed
@GuillaumeRx
GuillaumeRx deleted the gr/remove-oxlint-suppressions branch October 12, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants