Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR updates the AUR packaging (
line-gtkandline-gtk-git) to depend on Arch's systemdenopackage and run the protocol sidecar directly from source (protocol/src/main.ts) instead of shipping the precompiledline-gtk-protocolbinary.Why
When installing
line-gtkvia AUR (makepkg), the default Arch build environment runsstripon all binaries. Becausedeno compileappends a serialized JavaScript/bundle section to the end of the binary, runningstripremoves that section completely.This corrupts
line-gtk-protocol, causing it to immediately crash on startup with:As a result, the GTK client fails to connect to the sidecar, loops through recovery attempts, and gets stuck showing "ไม่สามารถเริ่มระบบโปรโตคอลใหม่ได้" / "Failed to restart protocol" without displaying the login QR code.
How
Added deno to depends in both PKGBUILDs and removed the precompiled line-gtk-protocol binary during packaging.
Since the Rust client already checks for protocol/src/main.ts and falls back to running deno run ... via find_deno() when the compiled binary is absent.
Notes
Why not add
!strip:Adding options=('!strip' '!lto') to the PKGBUILD prevents makepkg from stripping line-gtk-protocol.
However, relying on system deno is cleaner for native Arch packages, it avoids bundling a ~90MB duplicate Deno runtime and plays nicely with Arch's standard packaging practices.