Repository navigation
Ask the per-type names of a catalog whose array accessors back no set - #193
Merged
estebanzimanyi merged 1 commit intoOct 12, 2026
Conversation
MobilityDB master (96d1c56c98) gives getValues and valueSet, which return a set, to temporal_valueset, and leaves the typed accessors returning an array of the values and its count (tint_values, tfloat_values and their siblings) without a tag. test_per_type_functions_carry_their_own_name asks tfloat_values for the sqlfn valueSet, so every run of the suite over MobilityDB master raises KeyError: 'sqlfn'. The test asks tfloat_value_bins for valueBins, the per-type function MobilityDB master tags with the SQL name of its own family, and test_an_array_accessor_backs_no_set_valued_function states the rule the catalog follows: temporal_valueset backs getValues, and the array accessors back no SQL function. Witness: tests/test_sqlfn_deployed.py over the catalog of MobilityDB master 57fac5e427, and over the catalog of 7cc7a5415b, before 96d1c56c98, where tfloat_values carries valueSet and the new test fails. Measured: the file passes 9 of 9 over the catalog of 57fac5e427, where it failed 1 of 8; the suite over the same source-tree catalog reads 522 passed and the 3 failures it reads at master, which the installed-header catalog of CI passes. Why: a test of the catalog asks what the catalog states for the MobilityDB it is derived from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MobilityDB master (96d1c56c98) gives getValues and valueSet, which return a set, to
temporal_valueset, and leaves the typed accessors returning an array of the
values and its count (tint_values, tfloat_values and their siblings) without
a tag. test_per_type_functions_carry_their_own_name asks tfloat_values for
the sqlfn valueSet, so every run of the suite over MobilityDB master raises
KeyError: 'sqlfn'. The test asks tfloat_value_bins for valueBins, the
per-type function MobilityDB master tags with the SQL name of its own family, and
test_an_array_accessor_backs_no_set_valued_function states the rule the
catalog follows: temporal_valueset backs getValues, and the array accessors
back no SQL function.
Witness: tests/test_sqlfn_deployed.py over the catalog of MobilityDB master
57fac5e427, and over the catalog of 7cc7a5415b, before 96d1c56c98, where
tfloat_values carries valueSet and the new test fails.
Measured: the file passes 9 of 9 over the catalog of 57fac5e427, where it
failed 1 of 8; the suite over the same source-tree catalog reads 522
passed and the 3 failures it reads at master, which the installed-header
catalog of CI passes.
Why: a test of the catalog asks what the catalog states for the MobilityDB
it is derived from.