Repository navigation
fix(everything-dev): stamp configured-only slots — authored means sourced, not configured - #680
Merged
Merged
Conversation
…rced, not configured (#679) authoredSlotPaths counted every plain-object app.<key> as authored, so a child setting auth: { variables, secrets } had app.auth skipped by release-scoped stamping. The auth server then followed the parent's live config pointer under a host and auth UI pinned to the child's release. A slot is now authored only when its entry names a code source (production, development, pin, extends, proxy), or is a ui:false opt-out or bare plugin ref. stampSlotRecord already merges, so variables and secrets survive the stamp. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #679.
The gap
Release-scoped stamping (#656) pins every inherited
app.*slot to the child's platform release — except slots the child authors.authoredSlotPathstreated anyapp.<key>object as authored, so a child that only configures its inherited auth (auth: { variables, secrets }— SIWN recipients, email sender, trusted origins, auth secrets) hadapp.authskipped. Onlyapp.auth.uiandapp.hostgot stamped; the auth server kept following the parent's live config pointer.Live today:
multiagentic.near→dev.multiagency.aiis pinned to rc.27, but its publishedapp.authcarries noproduction/pin, and the parent's liveapp.authhas already moved from rc.27's0e7c85b2…to61db1793…— a post-rc.27 auth server under an rc.27 host and auth UI. The composition gate only compares UI slots, so it doesn't catch this. Same story for remote-onlyapi: { variables, secrets }entries (#566).The fix
A slot is authored only when it names where its code comes from:
production,development,pin,extends, orproxy— plus the existingui: falseopt-out and bare-string plugin ref cases. Configuration alone (variables,secrets,routes, …) no longer opts a slot out of release pinning.stampSlotRecordalready merges into the existing entry, so the child's configuration survives the stamp.Unchanged:
path: "ui"canonicalizes todevelopment: "local:ui", and stamping reads the authored config beforelocal:targets are stripped.ui: falseopt-outs, and plugin slots (never stamped since fix(everything-dev): stamp app.* slots only — plugins are declaration-scoped (rc.26 child-deploy hotfix) #657).proxycounts as a source, so proxied slots keep today's behavior.ADR 0034's amendment is clarified to define "authored" this way (it previously assumed children never author
app.auth). Patch changeset included.Verification
tests/unit/composition.test.ts: configured-onlyapp.authis stamped with variables/secrets kept and workspaceui/apiuntouched; remote-onlyapp.apiis stamped, proxiedapp.apiis not;authoredSlotPathsexcludes configuration-only entries. The fixtures in the existingauthoredSlotPathstest now use real source keys instead of{ x: 1 }placeholders. All new tests failed before the fix.dev.multiagency.aibos.app.ts→toConfigInput+stripLocalDevelopmentTargets, stamped with the published rc.27 release manifest.app.auth.ui, app.host. That matches the live published config.app.auth, app.auth.ui, app.host.app.authis pinned to0e7c85b2…, allvariables/secretsare kept, andui/apiaren't stamped.pnpm --filter everything-dev test: 1695 passed, 3 skipped.tsc --noEmit,biome check .andpnpm run lint:effectare clean.🤖 Generated with Claude Code