Repository navigation
Use monotonic time for conditional wait deadlines - #5656
Open
fallintoplace wants to merge 1 commit into
Open
fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
Contributor
[High impact] This PR appears safe to merge. SummaryChanges
Reviews (1) · Last reviewed commit: "Use monotonic time for conditional wait ..." · Reviewed by Greptile |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5653.
Description
What: Keep conditional waits stable when the system clock changes.
Why: Wall-clock adjustments can make a finite FL wait time out early or run too long.
Implementation: Measure the timeout using
time.monotonic(). Add deterministic tests for backward and forward clock steps.Types of changes
./runtest.sh.Testing
./runtest.sh -sand pytest were unavailable without a checkout and style dependencies. Added focused regression tests for CI.Risk
Low. Only the clock used for elapsed timeout calculation changes; event, abort and callback ordering stays unchanged.