Skip to content

fix(setup): install the documented config/requirements.yml - #1435

Merged
dholt merged 1 commit into
NVIDIA:masterfrom
MaxFreedomPollard:fix/setup-config-requirements
Oct 22, 2026
Merged

dholt merged 1 commit into
NVIDIA:masterfrom
MaxFreedomPollard:fix/setup-config-requirements

Conversation

@MaxFreedomPollard

Copy link
Copy Markdown
Contributor

scripts/setup.sh is meant to install user-defined Galaxy collections and roles from config/requirements.yml. docs/deepops/configuration.md documents that file, and config.example/requirements.yml ships a template for it. The block that installs it is guarded by a check for a different file name:

if [ -d "${CONFIG_DIR}" ] && [ -f "${CONFIG_DIR}/requirement.yml" ] ; then
    cd "${CONFIG_DIR}"
    as_user ansible-galaxy collection install ... -r "requirements.yml"
    as_user ansible-galaxy role install ... -r "requirements.yml"
fi

config/requirement.yml never exists, so the block is always skipped and anything listed in config/requirements.yml is never installed. Playbooks that use those custom collections or roles then fail with a role-not-found or collection-not-found error. The typo came in with e4991dd, which added the existence check.

This PR changes the check to requirements.yml, the file the block already installs from.

Testing

With a config/ directory copied from config.example, the condition on master evaluates false (requirement.yml is absent), so the install is skipped. With this change it evaluates true and the two ansible-galaxy ... -r requirements.yml commands run. bash -n scripts/setup.sh passes. I did not run the full setup.sh on a provisioning host.

🤖 Generated with Claude Code

setup.sh installs user-defined Galaxy collections and roles from
config/requirements.yml, as docs/deepops/configuration.md and
config.example/requirements.yml describe, but the existence check looked
for config/requirement.yml. That file never exists, so the block was
always skipped and custom requirements were silently never installed.
The typo came in with e4991dd, which added the check.

Check for requirements.yml, the file the block then installs from.

Signed-off-by: Max Freedom Pollard <272618364+MaxFreedomPollard@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dholt
dholt merged commit 8e0fa14 into NVIDIA:master Oct 22, 2026
@dholt

dholt commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants