Repository navigation
[release-26.7] fix[device-plugin] add DEVICE_LIST_STRATEGY env var guardrail - #3107
Merged
Merged
Conversation
This commit adds additional validation to the devicePlugin operand transformation logic. When CDI is enabled, it is required that the DEVICE_LIST_STRATEGY env var value includes one of "cdi-annotations" and "cdi-cri". While the current transformation code adds these values to DEVICE_LIST_STRATEGY when .spec.cdi.enabled is true, the same resolved value gets overridden when the gpu-operator user sets the DEVICE_LIST_STRATEGY env var explicitly in the devicePlugin section of the ClusterPolicy custom resource. This changes addresses a major limitation in the gpu-operator where feedback from an invalid devicePlugin config only happens at gpu pod workload scheduling which is a significant delay. This provides a poor UX as users waste hours debugging the containerCreate failures instead of identifying the invalid devicePlugin config. This fix changes that by failing at the ClusterPolicy reconcile stage. Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com> (cherry picked from commit 54cc02c)
github-actions
Bot
requested review from
cdesiniotis,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
October 21, 2026 22:04
Contributor
|
/ok to test 8247b00 |
tariq1890
approved these changes
Oct 21, 2026
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
coverage: 39.21% (+0.05%) from 39.16% — backport-3081-to-release-26.7 into release-26.7 |
rahulait
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Automated backport of #3081 to
release-26.7✅ Cherry-pick completed successfully with no conflicts.
Original PR: #3081
Original Author: @tariq1890
Cherry-picked commits (1):
54cc02cfix[device-plugin] add DEVICE_LIST_STRATEGY env var guardrailThis backport was automatically created by the backport bot.