Repository navigation
give up lambda-based mangling of __sexpr tparams - #2313
Merged
Merged
Conversation
Collaborator
Author
|
/ok to test 6ff6ee9 |
Collaborator
Author
|
/ok to test d8fa801 |
ericniebler
force-pushed
the
remove-make-sexpr
branch
from
October 9, 2026 03:04
d8fa801 to
e96995c
Compare
ericniebler
force-pushed
the
remove-make-sexpr
branch
from
October 9, 2026 03:07
e96995c to
bfe721f
Compare
Collaborator
Author
|
/ok to test bfe721f |
ericniebler
force-pushed
the
remove-make-sexpr
branch
from
October 9, 2026 03:34
bfe721f to
6cc8b2f
Compare
Collaborator
Author
|
/ok to test 6cc8b2f |
ericniebler
force-pushed
the
remove-make-sexpr
branch
from
October 9, 2026 04:05
6cc8b2f to
e80205f
Compare
Collaborator
Author
|
/ok to test e80205f |
ericniebler
changed the title
__make_sexpr helper__sexpr tparams
romintomasetti
added a commit
to uliegecsm/kokkos-execution
that referenced
this pull request
Oct 9, 2026
_WITH_PRETTY_SENDER_ disappeared in NVIDIA/stdexec#2313 (as well as the attempt to mangle/reduce the length of the sender types) Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>
romintomasetti
added a commit
to uliegecsm/kokkos-execution
that referenced
this pull request
Oct 9, 2026
_WITH_PRETTY_SENDER_ disappeared in NVIDIA/stdexec#2313 (as well as the attempt to mangle/reduce the length of the sender types) Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>
romintomasetti
added a commit
to uliegecsm/kokkos-execution
that referenced
this pull request
Oct 9, 2026
_WITH_PRETTY_SENDER_ disappeared in NVIDIA/stdexec#2313 (as well as the attempt to mangle/reduce the length of the sender types) Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>
romintomasetti
added a commit
to uliegecsm/kokkos-execution
that referenced
this pull request
Oct 9, 2026
_WITH_PRETTY_SENDER_ disappeared in NVIDIA/stdexec#2313 (as well as the attempt to mangle/reduce the length of the sender types) Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>
romintomasetti
added a commit
to uliegecsm/kokkos-execution
that referenced
this pull request
Oct 9, 2026
_WITH_PRETTY_SENDER_ disappeared in NVIDIA/stdexec#2313 (as well as the attempt to mangle/reduce the length of the sender types) Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>
romintomasetti
added a commit
to uliegecsm/kokkos-execution
that referenced
this pull request
Oct 9, 2026
_WITH_PRETTY_SENDER_ disappeared in NVIDIA/stdexec#2313 (as well as the attempt to mangle/reduce the length of the sender types) Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>
romintomasetti
added a commit
to uliegecsm/kokkos-execution
that referenced
this pull request
Oct 9, 2026
_WITH_PRETTY_SENDER_ disappeared in NVIDIA/stdexec#2313 (as well as the attempt to mangle/reduce the length of the sender types) Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>
romintomasetti
added a commit
to uliegecsm/kokkos-execution
that referenced
this pull request
Oct 9, 2026
_WITH_PRETTY_SENDER_ disappeared in NVIDIA/stdexec#2313 (as well as the attempt to mangle/reduce the length of the sender types) Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>
romintomasetti
added a commit
to uliegecsm/kokkos-execution
that referenced
this pull request
Oct 9, 2026
_WITH_PRETTY_SENDER_ disappeared in NVIDIA/stdexec#2313 (as well as the attempt to mangle/reduce the length of the sender types) Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>
romintomasetti
added a commit
to uliegecsm/kokkos-execution
that referenced
this pull request
Oct 9, 2026
_WITH_PRETTY_SENDER_ disappeared in NVIDIA/stdexec#2313 (as well as the attempt to mangle/reduce the length of the sender types) Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>
romintomasetti
added a commit
to uliegecsm/kokkos-execution
that referenced
this pull request
Oct 9, 2026
_WITH_PRETTY_SENDER_ disappeared in NVIDIA/stdexec#2313 (as well as the attempt to mangle/reduce the length of the sender types) Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
efforts to bring down the identifier length of sender types cause too many problems. parameterize
__sexpron the tag, data, and child senders instead of on a lambda that returns a descriptor.this change results in longer sender identifiers. to ameliorate that issue, the
just*senders get their own sender types that inherit from__sexprinstead of using__sexprdirectly. likewise for thethenandupon_(error|stopped)senders.also, the
__make_exprhelper function causes an extra moves of the data and child parameters. rather than calling a function to make an__sexpr, just make the__sexprdirectly with the help of CTAD. that way we benefit from deferred materialization of temporaries.