Repository navigation
Fix just_from sink return type - #2318
Open
fallintoplace wants to merge 2 commits into
Open
fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
Contributor
|
What's the use case for Since invoking |
Contributor
Author
|
Fair point, I agree that doing work after completion should be avoided. The intended use case is actually the documented return sink(42, 3.14); example in include/exec/just_from.hpp. The probe sink returns completion_signatures, but the runtime sink returns void, so the documented pattern fails to compile when the operation is started. This change makes the two consistent without requiring additional work after completion. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Return completion signatures from the
just_fromsink.Why
Callbacks using
auto completions = sink(42);currently fail to compile.Implementation
Make the runtime sink return the same type as the probe. This also fixes
just_error_fromandjust_stopped_from.