Repository navigation
Conversation
The breadcrumb set aria-current="page" on its last crumb unconditionally, so with a nav item also marked current, screen readers announced two current pages. A crumb is now current only when its href is the pathname. The last crumb keeps its visual emphasis. Also make the tip comments say what the types enforce (required on Crumb/NavItem/AccountMenu, optional only for custom CornerTip use) and describe BuildVersion's actual env contract. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UAYrDDPPupKfj2gXkb9ih3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-current="page"on its last crumb unconditionally. With the top-right nav also marking the active page, screen readers announced two current pages (e.g. on /keys: both "LLM" and "金鑰").Changes
registry/winlab/blocks/app-shell/app-shell.tsxaria-current="page"only when its href equals the pathname (exact match). The last crumb keepstext-foreground.CornerTipmay omittip.NEXT_PUBLIC_BUILD_SHA,NEXT_PUBLIC_BUILD_TIMEand optionalNEXT_PUBLIC_BUILD_URLset by the consuming app's build; shows "dev" when the SHA is unset.npx shadcn@latest add @winlab/app-shell -o.Test plan
bun run theme:check,tokens:checknpm run lint,typecheck,format:checknpm run build(shadcn build + next build)🤖 Generated with Claude Code
https://claude.ai/code/session_01UAYrDDPPupKfj2gXkb9ih3