Repository navigation
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
🟡 Changes recommended
The region checks in three scripts eagerly invoke inArray even for nonmatching regions, creating unnecessary subshells before resource queries begin.
1 open issue
What changed in this PR
This PR prevents duplicate AWS regional-table entries from causing repeated region queries in the FSx for NetApp ONTAP listing utilities.
Changes:
- Adds region membership checks to avoid duplicate regions.
- Preserves a preconfigured
excludeRegionsvalue. - Suppresses output from background-job
waitcalls.
| File | Description |
|---|---|
Management-Utilities/fsx-ontap-aws-cli-scripts/list_fsxn_volumes |
Adds region deduplication, preserves exclusions, and silences wait output for volume listings. |
Management-Utilities/fsx-ontap-aws-cli-scripts/list_fsxn_svms |
Applies the same changes to storage virtual machine listings. |
Management-Utilities/fsx-ontap-aws-cli-scripts/list_fsxn_filesystems |
Applies the same changes to filesystem listings. |
Review effort: Balanced
| # | ||
| # Since for some crazy reason AWS decided to add duplicate entries in their | ||
| # regional table, we need to make sure we don't add duplicates to our list of regions. | ||
| if [ $reg == $fsxnReg -a $(inArray $reg "${regions[*]}") == "false" ]; then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.