Repository navigation
Conversation
sp16743
requested review from
piyush5netapp,
rajiv-jain-netapp,
sandeeplocharla and
suryag1201
as code owners
October 20, 2026 12:16
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 25.78% |
| Branch coverage | 20.07% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
sp16743
force-pushed
the
bugfix/CSTACKEX-348
branch
from
October 27, 2026 16:16
f9b9e50 to
9a18590
Compare
suryag1201
reviewed
Nov 3, 2026
|
|
||
| FileInfo file = new FileInfo(); | ||
| file.setPath(OntapStorageUtils.toFlexVolRelativePath(sourceVolumePath, flexVolName)); | ||
| String relativeSourcePath = OntapStorageUtils.toFlexVolRelativePath(sourceVolumePath, flexVolName); |
There was a problem hiding this comment.
add example as a comment for relative path and similarly for path in file.setPath()
suryag1201
reviewed
Nov 3, 2026
| sourcePath, destinationPath, flexVolName, snapshotName); | ||
| try { | ||
| FileCloneRequest request = new FileCloneRequest(flexVolUuid, flexVolName, sourcePath, destinationPath, snapshotName); | ||
| FileCloneRequest request = new FileCloneRequest(flexVolUuid, flexVolName, sourcePath, destinationPath); |
There was a problem hiding this comment.
Since the snapshot name has been removed from the constructor, the corresponding constructor in the FileCloneRequest model is no longer required. Could you please remove that constructor as well as the snapshotName field, since it is no longer being used
suryag1201
reviewed
Nov 3, 2026
| request.setVolumeInfo(volumeInfo); | ||
| request.setFile(file); | ||
| request.setDestinationPath(OntapStorageUtils.toFlexVolRelativePath(volumeInfo.getUuid(), flexVolName)); | ||
| request.setSnapshotName(snapshotName); |
There was a problem hiding this comment.
this should not be required now as it is already set as a path.
Similarly check other places for setter and getters for this snapshot name for file and remove that
suryag1201
reviewed
Nov 3, 2026
| * Builds the request that clones a file out of a FlexVolume snapshot into a new file named after | ||
| * the volume uuid, inside the same FlexVolume. | ||
| */ | ||
| private CloudStackVolume createCloneFileFromSnapshotRequest(StoragePoolVO storagePool, Map<String, String> details, |
There was a problem hiding this comment.
check the file for comments related to snapshot.name and update it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Creating a NFS volume from an ONTAP snapshot sent POST /api/storage/file/clone with a separate snapshot field. That API has no snapshot property, so ONTAP returned 400, code 262179, Unexpected argument "snapshot".
The snapshot source now goes in source_path, which is what the file-clone API accepts:
./.snapshot/ < snapshot-name > / < source-file >
createCloneFileFromSnapshotRequest builds that path. cloneCloudStackVolume sends the 4-argument FileCloneRequest and no longer sets snapshot.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before the fix:
After the fix:
Tested on 9.15.1 ONTAP Filer:
How Has This Been Tested?
How did you try to break this feature and the system with this change?