Skip to content

[CSTACKEX-368] Resize Form Size issue fix - #134

Merged
suryag1201 merged 1 commit into
mainfrom
feature/CSTACKEX-368
Nov 2, 2026
Merged

suryag1201 merged 1 commit into
mainfrom
feature/CSTACKEX-368

Conversation

@suryag1201

@suryag1201 suryag1201 commented Nov 1, 2026 •

Copy link
Copy Markdown

Description

Issue: what happens when the volume isnt a whole number of gb, like a root disk from a 2.2 gb template? resize only takes whole numbers so hitting ok without touching the size looks like it fails

Fix: Leave 2.2 visible in the Size field. If the user does not change it, do not include that value in the submit. The current disk size is then left as it is, so a 2.2 GB disk and an IOPS-only change both succeed. If the user enters a new whole-GB size, send that value.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot 2026-11-01 at 8 58 39 PM

How Has This Been Tested?

Created a VM with root volume, having size same as template 3.5 GB
1- Click Resize, change only IOPS, did not change the size (3.5GB) - success
2- Click Resize, change size 3.5GB to 4 GB - success
3- Click Resize, no change at all - success

How did you try to break this feature and the system with this change?

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown

🔴 Test Coverage Grade: D — Marginal

Metric Value
Line coverage 25.82%
Branch coverage 20.09%

Grade Scale

Grade Line Coverage Meaning
🟢 A ≥ 80% Excellent - this code sleeps well at night 😴
🟡 B 60-79% Good - almost there, don't stop now 😉
🟠 C 40-59% Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D 20-39% Marginal - boldly shipping where no test has gone before 🖖
⛔ F < 20% Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run

@sandeeplocharla

Copy link
Copy Markdown
Collaborator

@suryag1201 the screenshot alone might confuse the reviewer. If possible, capture images for everything you mentioned under How Has This Been Tested? section, and add some explanation to the screenshot that you added here, when you cherry-pick this to upstream.

@suryag1201
suryag1201 merged commit d4221de into main Nov 2, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants