Repository navigation
Conversation
✅ Response Tests PassedAll test cases are passing successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LR4 repo was empty, so its cars fell back to the Land Rover make repo, which has few reads for this generation. This seeds it with 100 commands and 108 signals, most of them debug commands for the cars to try.
What the 2016 captures answered (90 captures, all one model year):
732 22 D928:00,01,02and03decode as Park, Reverse, Neutral and Drive.7E0, replying from7E8:033E: 3,102-19,989 kPa;0520: 33-88 °C;F40C: 0-3,128 rpm;F442: 10.8-14.7 V.The engine refused
00E6,00F2,00F3,5200, theD9xxblock andF18D-F300. Those are left out.Candidates:
Most reads come from Add LR4 commands #5 by @mwvolo, written on a 2016 LR4:
7D3;7E0;7E1;792,761and795reads.Its fuel-rate and fuel-economy synthetics are left out, along with the helper signals that only fed them.
Transmission, wheel speed and brake reads from the Defender repo on
7E1,7E6and726, as candidates.Changes to the community PR's reads:
00(Park) as "no".LR4_ODO.generations.yamlcovers 2010-2016.Response tests pass (6), and schema validation and lint are clean. 6 fixtures are added and none deleted. The 2016 support file no longer lists twelve Service 01 PIDs as supported: the capture refused them, and the regenerated support data agrees.