Repository navigation
fix: keep unsaved automation edits; Dock page leads with what works - #136
Merged
Merged
Conversation
The automation editor's draft lived in view state, so leaving the Automation page and coming back replaced unsaved edits with the saved script. It now lives in AutomationController, with an Unsaved changes mark beside the buttons. Enabling the extension runs the saved script — it used to apply and save whatever was in the editor, though the page says only Save applies edits. Save stays available while running, where it doubles as Reload. With the BarShelf Dock off, the Dock page shows profiles, the Apple Dock layout and switching first; the BarShelf Dock's appearance and items follow for when it is turned on. Found in a design/UX review with a codex peer. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two UX fixes from the peer review.
Automation editor
@State, so leaving the Automation page and coming back discarded unsaved edits. It now lives inAutomationController.draft, and an "Unsaved changes" mark appears beside the buttons. Korean translation included.testUnsavedDraftOutlivesTheEditorAndClearsWhenItMatchesTheSavedScript.Dock page
Testing:
swift testpasses andsync-strings --checkis ok.🤖 Generated with Claude Code