Repository navigation
OpenConceptLab/ocl_issues#2948 | Results tables: tinted header row with bold labels - #71
Merged
Merged
Conversation
… row (surface.s90) framed by surface.nv80 rules The header row of TableResults and the grouped references table now uses the surface.s90 token instead of white, keeping its bold labels. The header cells and the results toolbar above them get a 1px surface.nv80 rule, so the header stays a distinct band when the toolbar shows a selection (primary tint) and when the selected row (primary.90, almost the same value as surface.s90) sits right under it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TjM9dGow2KV1Gwr2dWQdph
paynejd
commented
Oct 22, 2026
paynejd
left a comment
Member
Author
There was a problem hiding this comment.
Codex review, pass 1 (codex-cli 0.163.0, commit eccd8c7)
Verdict: clean. No findings.
findings.json
{
"reviewer": "codex-cli 0.163.0",
"perspective": "defects",
"mode": "full",
"commit": "eccd8c7f",
"verdict": "clean",
"prior": [],
"findings": []
}
Member
Author
|
Design-system page for this treatment: OpenConceptLab/ocl-design-system#17 (TableResults page, merge after this PR). |
Member
Author
|
Simplification review (Claude subagent, commit eccd8c7) Verdict: clean. Nothing to cut: each of the six style changes serves an acceptance criterion. No commits after the Codex pass, so no follow-up check was needed. simplify.json{
"reviewer": "claude subagent",
"perspective": "simplify",
"mode": "full",
"commit": "eccd8c7f",
"verdict": "clean",
"prior": [],
"findings": []
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Implementer feedback on TBv3: the results-table header row was white like the rows under it, so the columns were hard to pick out.
surface.s90(#e3e0f9), applied asbgcolor: 'surface.s90'on the header row ofTableResults(concepts, mappings, references, repos, orgs, users) and of the grouped references table (ReferenceSourceGroupedResults), which shared the same header style. Labels were already bold (<b>, weight 700) and stay that way.surface.nv80rule above and below the header (the outline token TBv3 already uses for dividers). The bottom rule is on the header cells. The top rule is the results toolbar's existing bottom border, which changes fromrgba(224, 224, 224, 1)to the same token. This is a judgment call beyond the ticket's colour decision. The selected row's highlight (primary.90,#e2dfff) andsurface.s90are almost the same value, and the toolbar's selection tint is close too. Without the rules, a selected first row and a toolbar with a selection merge into one lavender block with the header (compare the zoomed "selected" shots below). If you'd rather separate them by colour, the selected-row highlight would need its own decision.The design-system page that documents this treatment is in OpenConceptLab/ocl-design-system (linked in a comment below once it's open).
How I verified it
rgb(227, 224, 249)with labels at weight 700: global search, CIEL concepts, a selected row, a scrolled table, grouped references, and the ungrouped references table with the translation toggle.eslint --ext .jsx,.js src/is clean, andnpm testpasses (20 of 20). No unit test was added, because the change is styling only.Screenshots
Public content only (global search for "malaria", CIEL source, CIEL/MPX collection). The
screenshots/ocl_issues-2948branch holds only these images and can be deleted after review.closes OpenConceptLab/ocl_issues#2948
🤖 Generated with Claude Code
https://claude.ai/code/session_01TjM9dGow2KV1Gwr2dWQdph