Repository navigation
Keep authored dataclass subtypes during nested configuration merging - #15
Merged
Merged
Conversation
Contributor
Author
|
Planck owns the normal ObjectState 1.2.0 publication/installed receiving follow-through for OpenHCS #663. Current reviewed main 27dbe36 includes merged #15, #17 and the declared 1.2.0 API release #19. Official PyPI 1.2.0 metadata is currently absent; v1.2.0 tag and active publisher job are absent. I will qualify the ordinary Hatch artifacts, then use the existing trusted publish.yml tag workflow without changing source/version or existing installations. Current OpenHCS scientist bundles remain untouched. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An authored nested dataclass subtype could cause
config_contextto drop its entire containing override: the merge read subtype-only fields from the default base instance and raisedAttributeError. A volume spatial declaration consequently lost all image source bindings, and fresh OpenHCS original 3D CellProfiler import failed on an unknownorigDNAartifact.The existing nested merge now retains the authored nominal owner and its additional fields. Shared fields still inherit base values for
Noneoverrides, explicit masking still retainsNone, and lazy overlays of the same canonical owner retain the base-owner merge. An explicit authored change back to the base nominal type is respected. No importer workaround or alternate merge authority is introduced.Validation: 49 existing/new context, lazy, global configuration and integration controls passed. Three public-context regressions reproduced the loss before the fix. Source-qualified fresh import of the actual
3d_monolayer_final.cppipenow produces 31 steps, retainsorigDNA,origMito,origMemb, and preservesVolumeSourceSpatialDomain. This is correctness qualification, with no pipeline timing claim.Closes #14