Read exact saved text through source backends - #26
Merged
Merged
Conversation
Closes #25. Expose DataSource.load_text through FileManager; disk preserves exact UTF-8 bytes and Zarr retains its existing disk-passthrough owner. Text-valued memory storage derives the default source behavior, while structured values refuse it. Required by OpenHCSDev/openhcs#394 to reuse saved analysis tables instead of rendering them again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25.
Saved CSVs could only be loaded through the structured CSV decoder, forcing consumers to render table text again or bypass their storage backend. Add
DataSource.load_textand route it through FileManager. Disk reads exact UTF-8 bytes, Zarr uses its existing disk passthrough, and memory retains already stored text. Structured values refuse the text contract.This is the production dependency for OpenHCSDev/openhcs#394's consolidation and warm-debug reuse of actual saved writer output. It adds no registry, carrier or caller-side backend dispatch.
Validation: five existing disk/text consumer cases passed, including exact CRLF save/read through disk, Zarr and memory, structured-memory rejection, and unchanged decoded CSV loading. No performance claim is made for this capability itself.