Repository navigation
FLASHApp 1.1.0: FLASHAnnotator step, current FLASHTnT/FLASHDeconv, Lysate/Native presets - #104
Open
t0mdavid-m wants to merge 4 commits into
Open
t0mdavid-m wants to merge 4 commits into
t0mdavid-m wants to merge 4 commits into
Conversation
… ':' (#413) A pattern such as "fd:" now selects every parameter under that top-level section, so a workflow can hide a subsection that does not apply to it without listing each parameter. Plain names keep their suffix matching. Claude-Session: https://claude.ai/code/session_01P4MTpJCZMdSHNRFixkxcnz Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit bf361e58baf6768d116d9abdc2aa95542ae404e6)
Pipeline (TagWorkflow): DecoyDatabase (skipped when the FASTA already has decoys or is PEFF) -> FLASHDeconv -> FLASHTnT (-db, -in_raw) -> FLASHAnnotator on the proteoform file. Every TOPP step is gated on success. - configure(): FLASHAnnotator tab; FLASHTnT's fd: section excluded (the FLASHDeconv tab already covers it); FLASHTnT ion types passed on to FLASHAnnotator. - New src/parse/annotator.py: FLASHAnnotator fragments (terminal and internal) in database coordinates, plus per-proteoform summary; stored as annotated_fragments / annotation_summary in sequence data. - Manual upload accepts the FLASHAnnotator outputs. - New example datasets (8 E. coli top-down spectra) replace the AqpZ demo. - Docker: build OpenMS from FDmerge. - polars pinned <2 (2.0 removed with_row_count); with_row_index used. - Vue bundle rebuilt with the sequence-view internal-ion visualization. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P4MTpJCZMdSHNRFixkxcnz
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- presets.json: "Lysate" and "Native" for the FLASHTnT workflow (FLASHTnT -native off/on). - FLASHTnT and FLASHAnnotator bool parameters are valueless flags; they are now declared as flag_parameters. Without it, switching one on passed "-native true", which FLASHTnT aborts on. - Version 1.0.1 -> 1.1.0 (settings.json, Windows build name). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P4MTpJCZMdSHNRFixkxcnz
FDmerge's create_cpp_extension.py still passes include_boost, which
autowrap 0.24 removed ("generate_code() got an unexpected keyword argument
'include_boost'" in make pyopenms). 0.23.0 is the version FDmerge's own
requirements history pins and what this Dockerfile used before the 0.24
bump; the Cython < 3.3 cap still applies.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01P4MTpJCZMdSHNRFixkxcnz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Tom · project thread
Updates the deployment to the FLASH* tools on t0mdavid-m/OpenMS
FDmergeand adds FLASHAnnotator as the source of fragment ion annotations. Version is now 1.1.0.Pipeline (
TagWorkflow.execution)DECOY_entries or the database is PEFF. FLASHTnT now requires decoys.-dband-in_raw. If FLASHTnT writes no protein or tag output, header-only TSVs are written so parsing and the viewer still work.-out,-out_annotation), using FLASHTnT'sion_type.Each TOPP call now checks
run_topp's return value, andexecution()returns False when inputs are missing.Configure
fd:section is hidden because the FLASHDeconv tab already covers it. This relies on the section-prefixexclude_parametersfrom streamlit-template #413, cherry-picked as the first commit.nativeoff, i.e. the default search) and Native (nativeon).native,keep_decoy,tag:allow_gap, …) are valueless flags. They are now declared asflag_parameters. Before, switching one on passed-native true, and FLASHTnT aborts with "Trailing text argument(s) '[true]'". Ondeveloponly three were declared; the other eight would fail the same way.Parsing and viewer
src/parse/annotator.py. It converts FLASHAnnotator's terminal and internal envelopes into fragments in database-sequence coordinates, plus a per-proteoform summary. Both are stored in the sequence-data parquet asannotated_fragments/annotation_summary, and the schema is extended for them.js-component/distis rebuilt from Sequence view: FLASHAnnotator fragments and internal-ion visualization t0mdavid-m/openms-streamlit-vue-component#32, which adds the internal-ion visualization in the Sequence View. The Docker image builds the Vue bundle fromFVdeploy, so that PR has to be merged before the deployed image includes it.Deployment, version and data
DockerfileandDockerfile.arm:OPENMS_BRANCHchanged fromFVdeploytoFDmerge.settings.jsonand in the Windows build name.polars>=1.0,<2. Version 2.0 removedwith_row_count, which broke parsing on a fresh install; the code now useswith_row_index.Not changed:
example-data/workspaces/default/flashtnt/cachestill holds old results. The viewer reads<workspace>/cache, not that folder, so nothing uses it.Testing
pytest tests/: 181 passed, including the newtests/test_annotator_parse.py.pylint --errors-only: no new errors. The remaining ones are in files this PR doesn't touch, or are pyopenms name lookups that depend on the environment.FLASHTnT … -nativeruns;-native trueaborts, which is what the flag declaration fixes.🤖 Generated with Claude Code
https://claude.ai/code/session_01P4MTpJCZMdSHNRFixkxcnz