Repository navigation
Use OpenMS-Insight tables on the downstream pages (#38 rebased onto main's helper) - #41
Merged
Merged
Conversation
Replace st.dataframe with a server-side paginated Insight Table so only the visible page is sent to the browser on full-scale datasets. - Add show_insight_table() in common.py (also used by show_table()): reuses the on-disk cache unless the data changed, converts pandas to Polars and handles special column names - Switch Filtering, Imputation, Normalization, Statistical, PCA, Pathway/Enrichment and ProteomicsLFQ tables to it - Render results from session_state outside the button block, since Insight components trigger a rerun on first render that would otherwise clear them - Document the convention in CLAUDE.md and add unit tests Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Main gained src/common/insight_tables.show_insight_table in #36, so the duplicate helper in common.py is dropped. What this PR still adds moves onto main's helper: - downstream pages (filtering, imputation, normalization, statistics, PCA, pathway analysis, ProteomicsLFQ results) and show_table() render Insight tables instead of st.dataframe - tables without source files are cached by a content fingerprint, and the cache directory defaults to <workspace>/insight_tables - a named index is kept as a column - step results render from session state, outside the button block The GO tables on the enrichment page stay st.dataframe: they are only drawn inside the button block, where an Insight table's first-render rerun would wipe them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AUsQzDsQUXSRsys1GoQW3G
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Tom · project thread
Before: Filtering, Imputation, Normalization, Statistics, PCA, Pathway Analysis and the ProteomicsLFQ results draw their tables with
st.dataframe. That sends the whole table to the browser on every rerun, so these pages crawl on full-scale data.After: these pages show server-side paginated OpenMS-Insight tables, like the Abundance page already does. Each step's result stays visible after the page reruns.
This carries #38 by @hjn0415a forward. It contains their commit plus a merge of current main. Main gained its own
show_insight_tableinsrc/common/insight_tables.py(#36) while #38 was open, so the duplicate helper #38 added tocommon.pyis dropped and its new parts move onto main's helper:<workspace>/insight_tables.show_table()uses the Insight table.One deliberate difference from #38: the GO tables on the enrichment page stay
st.dataframe. They are only drawn inside the "Run GO Enrichment" button block, where an Insight table's first-render rerun would wipe them, and they are small.How: I merged main into #38's head, resolved the six page conflicts on main's versions, and reapplied #38's page changes.
pytest tests/passes (114 tests) on Python 3.12 with requirements.txt. I opened this PR because the fork branch behind #38 can't be pushed to from here. If merged, it supersedes #38.Generated by Claude Code