Repository navigation
Filtered PSMs: fragment mass error plot and b/y ion table for the selected PSM - #44
Open
t0mdavid-m wants to merge 1 commit into
Open
t0mdavid-m wants to merge 1 commit into
t0mdavid-m wants to merge 1 commit into
Conversation
…ected PSM Third step towards feature parity with the ProSE web app's PSM view. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D5Wo2FHPpi5a8X6GppNxEk
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Tom · project thread
Before: the Filtered PSMs page shows the annotated MS2 spectrum and the fragment coverage of the selected PSM. The per-ion evidence exists only as the
*_fragment_ions.tsvexport, with nothing in the app to look at it.After: under the spectrum there is a new "Fragment ions" section for the selected PSM. It has a fragment mass error plot (m/z against error, in the fragment tolerance's unit from the Comet settings, with the ±tolerance band shaded, b ions in blue, y ions in orange, and dots sized by intensity) and a b/y ion table (theoretical m/z per position at charge 1+ and, for precursors with charge ≥3, 2+, with matched cells highlighted).
This is ProSE parity items P2 and P4.
How:
src/common/fragment_plots.pyreads only the selected PSM's rows from the run's fragment ion export with a lazy polars scan. It computes the theoretical b/y ions with pyOpenMSAASequence. Neutral-loss matches such asb4-H2Oappear in the plot but don't mark a table cell.content/results_filtered.pyreads the selection from the existing state manager and the tolerance from the workflow's params.json (CometAdapter-TMTin TMT mode).This PR is independent of #42 and #43: it touches neither
app.pynor the files those PRs change.Validation:
tests/test_fragment_plots.pyadds 5 tests, and the full suite passes (124 tests).pylint --errors-onlyis clean. I also rendered the page in Chromium on a synthetic workspace.Generated by Claude Code