Repository navigation
Test pull requests with wasm-jit by default - #367
Merged
Merged
Conversation
wasm-jit gives the same results as C and is cheaper to run, so a pull request is now simulated with `--simCodeTarget=wasm-jit` and compared against the wasm-jit job, the way that job runs it. - `pull_request_target` (`wasm-jit` or `C`) picks the target. - `pull_request_baseline` defaults to the job testing that target: `wasm-jit`, or `master` for C. `pr-report.py --baseline` defaults to `wasm-jit` as well. - `pull_request_node` defaults to ryzen-9950x, where both master and wasm-jit run. The cmake flags are now part of the cached omc's stamp, so a C and a wasm-jit build of the same pull request do not reuse each other. The cached wasm-jit, wasm-web and heavy_tests_wasm builds rebuild once. Assisted-by: Claude Opus 5.5
sjoelund
enabled auto-merge (squash)
October 5, 2026 07:03
sjoelund
disabled auto-merge
October 5, 2026 07:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wasm-jit gives the same results as C and is cheaper to run, so a pull request is now simulated with
--simCodeTarget=wasm-jitand compared against the wasm-jit job, the way that job runs it.pull_request_target(wasm-jitorC) picks the target.pull_request_baselinedefaults to the job testing that target:wasm-jit, ormasterfor C.pr-report.py --baselinedefaults towasm-jitas well.pull_request_nodedefaults to ryzen-9950x, where both master and wasm-jit run.The cmake flags are now part of the cached omc's stamp, so a C and a wasm-jit build of the same pull request do not reuse each other. The cached wasm-jit, wasm-web and heavy_tests_wasm builds rebuild once.
Assisted-by: Claude Opus 5.5