Repository navigation
Update oauth.c - #1750
Open
nancy-verma780 wants to merge 2 commits into
Open
Update oauth.c#1750nancy-verma780 wants to merge 2 commits into
nancy-verma780 wants to merge 2 commits into
Conversation
michaelrsweet
requested changes
Oct 9, 2026
michaelrsweet
left a comment
michaelrsweet
left a comment
Member
There was a problem hiding this comment.
So there are indentation issues in the changes, plus you lost the comment explaining the nonce validation step...
From a code perspective the two "if" blocks are no different from the one block. Left-to-right evaluation with parenthesis grouping the jnonce check and string comparison...
Refactor JWT and nonce validation logic for clarity.
Author
|
Hi @michaelrsweet, thank you for the feedback. I have streamlined the validation check into a single conditional statement, removed the nested layout, restored the original explanatory comment, and ensured the spacing matches the repository style guidelines. Ready for your re-review! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix indentation, restore comment, and streamline nonce validation
#1609