Skip to content

Trade search weapon type selection - #7538

Closed
mcmanustfj wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
mcmanustfj:6832
Closed

mcmanustfj wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
mcmanustfj:6832

Conversation

@mcmanustfj

@mcmanustfj mcmanustfj commented Apr 4, 2024 •

Copy link
Copy Markdown

Fixes #6832.

Description of the problem being solved: Can't change weapon class in trade search.

Especially useful if I have two 1h weapons and want to swap the second one to a shield (or vice versa)

Steps taken to verify a working solution:

  • Create build
  • Add weapon to weapon 2
  • Trade for these items
  • Find best
  • See new "Item Type" dropdown

After screenshot:

image

image

Notes:

  • Currently not doing all base classes, just the important ones
  • Only have possible offhand weapons/shields/quivers for weapon 2, but don't do any validation (i.e. will not stop you from getting a shield and a bow.

@mcmanustfj

Copy link
Copy Markdown
Author

if any other features start modifying the item class for trade lookup, I would suggest creating a lookup table with all the item types and query strings

@Paliak Paliak added the enhancement New feature, calculation, or mod label Apr 8, 2024
@Zames-Chang Zames-Chang mentioned this pull request May 25, 2024
1 task done
@guy1195

guy1195 commented Nov 6, 2025

Copy link
Copy Markdown

I want this so bad... Currently playing a spell build that can use a wand/dagger/sceptre, but trade search will only find whatever i currently have equipped.

@mcmanustfj mcmanustfj closed this Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trade search weapon type selection, currently only uses the equipped weapon type.

3 participants