Add Pokémon varieties to Pokédex by Lafoxnir · Pull Request #1695 · PokeAPI/pokeapi

Lafoxnir · 2026-10-07T10:10:39Z

Change description

This PR's purpose is to add Pokémon varieties inside the Pokédex (for example, in Alola Pokédex, Rattata has both his alolan and kantonian forms). It is linked to this issue #1266
Currently, the only Pokédex impacted by the change is the original-alola Pokédex (ID 16). It is fully implemented for this Pokédex and since the code has been updated with all the required models, next changes should be faster.

What to expect for the new data ? Here is an example of Rattata's entry in the original-alola Pokédex :

    {
      "entry_number": 15,
      "pokemon_species": {
        "name": "rattata",
        "url": "http://localhost:8000/api/v2/pokemon-species/19/"
      },
      "varieties": [
        {
          "pokemon": {
            "name": "rattata-alola",
            "url": "http://localhost:8000/api/v2/pokemon/10091/"
          },
          "order": 0
        },
        {
          "pokemon": {
            "name": "rattata",
            "url": "http://localhost:8000/api/v2/pokemon/19/"
          },
          "order": 1
        }
      ]
    },

The order is the same order at the one seen on Bulbapedia's page : https://bulbapedia.bulbagarden.net/wiki/List_of_Pok%C3%A9mon_by_Alola_Pok%C3%A9dex_number_in_Pok%C3%A9mon_Sun_and_Moon

AI coding assistance disclosure

No AI was used

Contributor check list

I have written a description of the contribution and explained its motivation.
I have written tests for my code changes (if applicable).
I have read and understood the AI Assisted Contribution guidelines.
I will own this change in production, and I am prepared to fix any bugs caused by my code change.

FallenDeity

also add tests for the new models/serializers etc

ps: a rebase is also needed

FallenDeity · 2026-10-13T14:20:38Z

+16,245,10057,1
+16,246,361,0
+16,247,362,0
+16,247,10074,0


should order be 0 for both base glalie and mega? similar for eggxecutor its 1 for both normal and alola can u check

FallenDeity · 2026-10-13T14:23:13Z

    build_generic((PokemonDexNumber,), "pokemon_dex_numbers.csv", csv_record_to_objects)

+    def csv_record_to_objects(info):
+        dex_number = PokemonDexNumber.objects.get(


should we use something like this to pre load a look up dict? PokemonDexNumber.objects.all() rather than multiple queries

I'm not sure since it is not done anywhere else in the file, and I don't know if it is pertinent since all we really need for an entry is the corresponding PokemonDexNumber

well currently it would execute one query everytime the fn is called its additional overhead once we add more games having a pre loaded dict on top level to fetch as a lookup cache would be much more efficient, i agree its not done elsewhere but thats because build.py is inefficient it does need a refactor :)

FallenDeity · 2026-10-13T14:25:42Z

@@ -0,0 +1,367 @@
+pokedex_id,pokedex_number,pokemon_id,order


i dont know why we have so many but will this be duplicated for all of these

They are all of the Sun/Moon/Ultra Sun/Ultra Moon Pokédexes, since they were divided by islnd and USUM are different from SM in their entries.
We will have one file, but yes, the entries will need to be duplicated on all these Pokédexes, and each of the other ones existing in the API, from the national and Kanto dexes all the way to the Z-A and Champions dexes.

FallenDeity · 2026-10-13T14:26:26Z

    @extend_schema_field(PokemonDexNumberSerializer(many=True))
    def get_pokedex_entries(self, obj: Pokedex) -> ReturnList[ReturnDict[str, Any]]:
        entries = (
            PokemonDexNumber.objects.filter(pokedex=obj)


we might need to prefetch the varieties here

I'm sorry I do not quite understand how to do this

we pre fetch pokemon species here we can also use prefetch_related to prefetch the varieties, basically instead of querying each variety present in a dex as individual query it would collapse it to a single query so overall 2 queries give it a read u might find some other blog posts online too https://www.compilenrun.com/docs/framework/django/django-performance/django-prefetch-related/

FallenDeity · 2026-10-13T14:40:00Z

+16,201,170,0
+16,202,171,0
+16,203,772,0
+16,204,774,0


from data/v2/csv/pokemon_dex_numbers.csv
but 774 is minior right i think u meant 773?

can you just review these entries i think 16,262,269 might be wrong too dex numbers shows smn else

FallenDeity · 2026-10-13T14:47:11Z

also i think this pr needs to be expanded a bit currently this pr would tell for pokedex whether its present in that dex but it dosent cover games we already have a mapping which i think we can extend https://github.com/PokeAPI/pokeapi/blob/master/data/v2/csv/pokemon_game_indices.csv we can add entries per mon available in game here with similar data we do for pokedex i have some exclusion lists which can be used for automated population https://github.com/PokeAPI/sprites/blob/0dc105d5b12416932f29b594078282ab4be045f5/scripts/tracker/common.py#L173-L416 also some additional logic which can be used to auto generate the whole csv https://github.com/PokeAPI/sprites/blob/master/scripts/tracker/build_sprite_index.py

currently its unused for example

https://pokeapi.co/api/v2/pokemon/rattata-alola

this along with a new field in version-groups endpoint is what i had in mind since after dexit its not guranteed all pokemon are in the pokedex right lot of mons are transferable etc

@jemarq04 @Naramsim what are your thoughts

Lafoxnir · 2026-10-14T08:13:08Z

also i think this pr needs to be expanded a bit currently this pr would tell for pokedex whether its present in that dex but it dosent cover games we already have a mapping which i think we can extend https://github.com/PokeAPI/pokeapi/blob/master/data/v2/csv/pokemon_game_indices.csv we can add entries per mon available in game here with similar data we do for pokedex i have some exclusion lists which can be used for automated population https://github.com/PokeAPI/sprites/blob/0dc105d5b12416932f29b594078282ab4be045f5/scripts/tracker/common.py#L173-L416 also some additional logic which can be used to auto generate the whole csv https://github.com/PokeAPI/sprites/blob/master/scripts/tracker/build_sprite_index.py

currently its unused for example https://pokeapi.co/api/v2/pokemon/rattata-alola

The idea of this PR was to have the exact order of the varieties in the Pokédex, to be able to say that for Alola Pokédex, Alolan Rattata is the first one to be shown in the Pokédex. I don't think your solution has this system after seeing it.

this along with a new field in version-groups endpoint is what i had in mind since after dexit its not guranteed all pokemon are in the pokedex right lot of mons are transferable etc

If a Pokemon is not in the game's Pokédex, it will not appear at all for the Pokédex, so even if it is transferable, the varieties will not appear, this behaviour will not change

I am open to all kinds of suggestions to make this better, I mainly took into account what was said in the #1266 on what to do as a base but maybe we can have something easier to do

FallenDeity · 2026-10-14T17:08:35Z

just to add i am not saying my solution is different from urs what change u made will still be there what i suggested will just build on top of it, so to clarify along with your change we can also have entries in the pokemon game indices which we already do have the mapping only thing missing is the data so basically the data ur right now generating for varities we can also map to game indices than just pokedex
tldr: we should be doing both ur change + updating the game indice csv too (ur change is accurate and solves #1266)

its 2 different problems both solve

ur solves the question whether this pokemon is in the dex
my suggestion is we can extrapolate the same data to answer the question if the pokemon is in the game (which is also a part of the dexit problem right? mon is usable in game/battle/tranferable but not in regional dex)

add pokemon varieties to pokedex

9c995cc

Lafoxnir force-pushed the feat/pokedex-default-pokemon-form branch from 765d38a to 9c995cc Compare October 7, 2026 12:10

FallenDeity requested changes Oct 13, 2026

View reviewed changes

Lafoxnir added 2 commits October 14, 2026 10:14

fix pokemon varieties in pokedex

5a139ed

Merge branch 'master' into feat/pokedex-default-pokemon-form

0adb873

Conversation

Lafoxnir commented Oct 7, 2026

Change description

AI coding assistance disclosure

Contributor check list

Uh oh!

FallenDeity left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FallenDeity commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Lafoxnir commented Oct 14, 2026

Uh oh!

FallenDeity commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

FallenDeity commented Oct 13, 2026 •

edited

Loading

FallenDeity commented Oct 14, 2026 •

edited

Loading