Skip to content

List user policies within the page limit in the live staging test - #3944

Merged
anth-volk merged 1 commit into
masterfrom
fix/live-test-user-policy-page-limit
Oct 15, 2026
Merged

anth-volk merged 1 commit into
masterfrom
fix/live-test-user-policy-page-limit

Conversation

@anth-volk

Copy link
Copy Markdown
Collaborator

Fixes #3943

Summary

  • The live staging test's _policy_ids helper asked GET /v2/user-policies for limit=1000. The Public API caps limit at MAXIMUM_QUERY_LIMIT (500), so the request got 422 and test_live_unauthenticated_users_round_trip_and_upgrade failed.
  • That test runs in "Deploy and test staging Cloud Run candidate", so the staging candidate was never promoted and the production steps were skipped. Run 38793955936 carries Stage 12A: Sign-in identity and v1-anchored user associations #3891 and Relay simulation run stage and progress on computing economy responses #3916, which are merged but not deployed.
  • The helper now imports MAXIMUM_QUERY_LIMIT from policyengine_api.query_parameters and asks for that, so the test and the API's limit can't drift apart again.

Testing

  • Not run locally: this is a live integration test that runs against the deployed staging candidate. The deploy run after this merges exercises it.
  • ruff format and ruff check pass on the changed file.

🤖 Generated with Claude Code

_policy_ids asked GET /v2/user-policies for limit=1000, but the Public API
caps limit at MAXIMUM_QUERY_LIMIT (500), so the request got 422 and the
signed-out round-trip test failed. That test gates the staging deploy, so
every merge to master stopped before production. The helper now asks for
MAXIMUM_QUERY_LIMIT.

Fixes #3943

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.49%. Comparing base (fc31955) to head (74d9afb).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3944       +/-   ##
===========================================
+ Coverage   47.76%   85.49%   +37.73%     
===========================================
  Files         239      255       +16     
  Lines       13374    14667     +1293     
  Branches     2300     2580      +280     
===========================================
+ Hits         6388    12540     +6152     
+ Misses       6363     1320     -5043     
- Partials      623      807      +184     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anth-volk
anth-volk marked this pull request as ready for review October 15, 2026 21:07
@anth-volk
anth-volk merged commit c91c835 into master Oct 15, 2026
13 checks passed
@anth-volk
anth-volk deleted the fix/live-test-user-policy-page-limit branch October 15, 2026 21:08

This branch was successfully deployed

1 active deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Live staging test asks for 1,000 user policies per page, above the API's 500 limit

1 participant